Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cover Block: Move Clear Media button from Inspector Controls to Block Controls. #64629

Closed
2 tasks done
rohitmathur-7 opened this issue Aug 20, 2024 · 1 comment · Fixed by #64630
Closed
2 tasks done

Cover Block: Move Clear Media button from Inspector Controls to Block Controls. #64629

rohitmathur-7 opened this issue Aug 20, 2024 · 1 comment · Fixed by #64630
Labels
[Block] Cover Affects the Cover Block - used to display content laid over a background image [Type] Enhancement A suggestion for improvement.

Comments

@rohitmathur-7
Copy link
Contributor

Description

The Clear Media Button is present in the Inspector Controls for the Cover block which makes it hard to notice,
The button should be present in Block Controls alongside Replace button so that all the buttons related to the media are present in one place only.

Step-by-step reproduction instructions

  • Go to the editor.
  • Add Cover Block.
  • Add Cover image.
  • The Clear Media button is present in Inspector Controls.

Screenshots, screen recording, code snippet

The Clear Media button is present in Inspector Controls of Cover Block:
cover-clear-media-inspector

Environment info

  • WordPress Version: 6.7-alpha-58915
  • Gutenberg Version: 19.0.0

Please confirm that you have searched existing issues in the repo.

  • Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

  • Yes
@rohitmathur-7 rohitmathur-7 added the [Type] Bug An existing feature does not function as intended label Aug 20, 2024
@rohitmathur-7 rohitmathur-7 mentioned this issue Aug 20, 2024
Merged
@rohitmathur-7 rohitmathur-7 changed the title Cover Block: Move Clear media button from Inspector Controls to Block Controls. Cover Block: Move Clear Media button from Inspector Controls to Block Controls. Aug 20, 2024
@Mamaduka Mamaduka added [Type] Enhancement A suggestion for improvement. [Block] Cover Affects the Cover Block - used to display content laid over a background image and removed [Type] Bug An existing feature does not function as intended labels Aug 20, 2024
@richtabor
Copy link
Member

Let's use the existing "Reset" terminology used elsewhere.

Here's the site logo:

CleanShot 2024-08-21 at 20 37 35

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[Block] Cover Affects the Cover Block - used to display content laid over a background image [Type] Enhancement A suggestion for improvement.
Projects
None yet
Milestone
No milestone
3 participants
@Mamaduka @richtabor @rohitmathur-7