Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should sidebar "Search categories" filter be a SearchControl? #64593

Closed
mirka opened this issue Aug 17, 2024 · 1 comment · Fixed by #64605
Closed

Should sidebar "Search categories" filter be a SearchControl? #64593

mirka opened this issue Aug 17, 2024 · 1 comment · Fixed by #64605
Labels
Good First Issue An issue that's suitable for someone looking to contribute for the first time [Package] Editor /packages/editor [Status] In Progress Tracking issues with work in progress [Type] Enhancement A suggestion for improvement.

Comments

@mirka
Copy link
Member

mirka commented Aug 17, 2024

What problem does this address?

The "Search categories" field in the Post sidebar uses a normal TextControl even though it's a search field.

Search categories input

<TextControl
// TODO: Switch to `true` (40px size) if possible
__next40pxDefaultSize={ false }
__nextHasNoMarginBottom
label={ filterLabel }
value={ filterValue }
onChange={ setFilter }
/>

What is your proposed solution?

@WordPress/gutenberg-design Should this be replaced with the SearchControl component, so it can signal that it's a search field, both visually and semantically? At the very least we should probably add back the type="search" attribute that seems to have been there in the past.

@mirka mirka added [Type] Enhancement A suggestion for improvement. [Package] Editor /packages/editor labels Aug 17, 2024
@jasmussen
Copy link
Contributor

I'd think so.

@mirka mirka added the Good First Issue An issue that's suitable for someone looking to contribute for the first time label Aug 19, 2024
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Good First Issue An issue that's suitable for someone looking to contribute for the first time [Package] Editor /packages/editor [Status] In Progress Tracking issues with work in progress [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants