-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stabilize Border Block Support Keys for WP 6.8 #64312
Comments
Hi @ndiego, I would like to work on the issue. Thank You, |
Hi @ndiego, I have created a draft PR - #64330, but I am seeing this PR needs lots of refactoring once the main referenced PR - #63401 is merged and working. This is because we can use a lot of things from the PR so we do not have redundant code issue happening. Also, there are ongoing discussion happening on the typography supports stabilization, hence I am aiming to wait for the typography support stabilizing to get merged in trunk and then we can pick up the pace on this issue with the PR. Though, I have once concern about the Thank You, |
@hbhalodia yes, any PR for this issue should follow the similar approach outlined in #63401. I would also recommend waiting until that PR is successfully merged. |
Thanks for the response, we can wait until #63401 PR gets merged. |
suspense! I hope it'll be backward compatible |
Related to:
Borrowing from the format of #63001, this issue outlines the tasks needed to stabilize the
__experimentalBorder
support. Doing so will make it easier for third-party extenders to confidently build custom blocks that provide border support and modify existing blocks with this support.Note that in order to provide backward compatibility for block plugins out in the wild, fallback support for the existing
__experimental
prefix should be provided.Stabilize the following border block support and associated properties:
__experimentalBorder
→border
__experimentalBorder.color
→border.color
__experimentalBorder.radius
→border.radius
__experimentalBorder.style
→border.style
__experimentalBorder.width
→border.width
Tasks
lib/block-supports/border.php
to use the non__experimental
prefix, falling back to the__experimental
prefix if available.__experimental
prefix, falling back to the__experimental
prefix if available.block.json
schema to support the non__experimental
prefixblock.json
files to use the non__experimental
prefixesblock.json
schema to remove the__experimental
prefix. Note that the code in WordPress should still support the__experimental
prefix, but at this stage, the experimental prefix will be treated as deprecated.The PR for this stabilization effort should follow the approach used to stabilize the typography supports in #63401.
The text was updated successfully, but these errors were encountered: