Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Columns (experimental)" wrong order of blocks on save #6339

Closed
manake opened this issue Apr 21, 2018 · 4 comments
Closed

"Columns (experimental)" wrong order of blocks on save #6339

manake opened this issue Apr 21, 2018 · 4 comments
Labels
[Feature] Nested / Inner Blocks Anything related to the experience of nested/inner blocks inside a larger container, like Group or P [Type] Bug An existing feature does not function as intended
Milestone

Comments

@manake
Copy link

manake commented Apr 21, 2018

(Post removed. Fixed.)

@noisysocks
Copy link
Member

noisysocks commented Apr 23, 2018

I'm able to reproduce this with these steps:

  1. Insert a Columns block
  2. Set the Columns block to have 4 columns
  3. Type 4 into the fourth column, 3 into the third column, etc.
  4. Switch over to the Code Editor

The markup is in the order that you type text into the columns rather than in the order that they appear on the frontend.

Note that this oddity doesn't cause anything to render badly. Still, it's best (e.g. for a11y) that the markup we generate reflects what the page will look like when viewed.

@noisysocks noisysocks added [Type] Bug An existing feature does not function as intended [Feature] Nested / Inner Blocks Anything related to the experience of nested/inner blocks inside a larger container, like Group or P labels Apr 23, 2018
@noisysocks noisysocks added this to the Merge Proposal: Editor milestone Apr 23, 2018
@benhuson
Copy link

benhuson commented May 8, 2018

I'm unsure that left, right, left right is the most logical order to structurally order the column contents.

Yes, top left to bottom right is the natural reading order for many languages. However, as we're talking about columns, imagine a newspaper or magazine article, or a row of product or article overview columns. The natural reading order when talking columns is 1st column top to bottom of first column, then 2nd column top to bottom.

My biggest use-case for a columns block layout would be for grouping content that should be read in this order. For example, column 1 with an image, heading, subheading and text, then column 2 with similar. In this instance, the logical sequence would be to view all column 1 content, then all column 2 content.

If your objective is to create a grid of content that should logical read left, right, left right, then to my mind that would be achieved by having a 2 column layout, followed by another 2 column layout.

That way the reading order is logical if the items are stacked, for example as a single column on mobile.

@melchoyce
Copy link
Contributor

Related, with some existing discussion: #5351

@ajitbohra
Copy link
Member

Unable to reproduce this on the master. Hence closing this for now, feel free to reopen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Nested / Inner Blocks Anything related to the experience of nested/inner blocks inside a larger container, like Group or P [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

No branches or pull requests

5 participants