Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iAPI Router: don't remove region when it's not present in the new page #63249

Open
luisherranz opened this issue Jul 8, 2024 · 0 comments
Open
Labels
[Package] Interactivity Router /packages/interactivity-router [Type] Bug An existing feature does not function as intended

Comments

@luisherranz
Copy link
Member

Description

Right now, if a page has a region and you navigate to a page that doesn't contain that region, the region gets deleted. We should consider whether this is the expected outcome or if it should instead maintain the regions intact if these regions are not found on the new page.

Step-by-step reproduction instructions

  1. Load a page that has a region using the data-wp-route-region directive and a block that navigates to a URL that doesn't have that region.
  2. Start the navigation.
  3. The region disappears.

Screenshots, screen recording, code snippet

No response

Environment info

No response

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes

@luisherranz luisherranz added [Type] Bug An existing feature does not function as intended [Packages] Interactivity /packages/interactivity [Package] Interactivity Router /packages/interactivity-router and removed [Packages] Interactivity /packages/interactivity labels Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Package] Interactivity Router /packages/interactivity-router [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

No branches or pull requests

1 participant