Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make usage of the search icon more consistent and meaningful #63023

Open
afercia opened this issue Jul 1, 2024 · 0 comments
Open

Make usage of the search icon more consistent and meaningful #63023

afercia opened this issue Jul 1, 2024 · 0 comments
Labels
[Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). Needs Design Feedback Needs general design feedback. [Package] Commands /packages/commands [Type] Bug An existing feature does not function as intended

Comments

@afercia
Copy link
Contributor

afercia commented Jul 1, 2024

Description

Similarly to #62873, to provide cohesive design language in the editor UI the usage of icons should be consistent. Icons should identify unique features or, at least, similar features.

The search icon is one of the most popular and familiar icons on the web. I'm not sure it's ideal to use it for features other than, well, a search.

In the Site editor it is used also for the Command palette. This is potentially confusing for users and particularly disorienting when the UI shows anoter search icon close to the command palette one. Actually, in some cases, the editor shows two very close search icons that are associated with entirely different features. Example screenshot:

Screenshot 2024-07-01 at 12 31 48

I'd tend to think the command palette should not use the search icon in the first place.

Another occurrence of icon={ search } is in the Image editor. When editing an image, the block toolbar shows a search icon that is associated with the Zoom feature. Screenshot:

Screenshot 2024-07-01 at 14 36 06

Also in this case I'd argue the search icon isn't the best one to use. Usually, zoom icons use a lens that either contains either a plus or minus sign. Example from the Material design icons:

Screenshot 2024-07-01 at 14 41 52

Step-by-step reproduction instructions

  • Go to the Site editor > Pages.
  • Observe that, regardless of whether the active view is List, Table, or Grid, the editor UI shows two search icon for two different features.
  • Add an Image block, set an image, and click Crop in the block toolbar.
  • Observe the toolbar shows a Zoom control with a search icon.

Screenshots, screen recording, code snippet

No response

Environment info

No response

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes

@afercia afercia added [Type] Bug An existing feature does not function as intended [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). Needs Design Feedback Needs general design feedback. [Package] Commands /packages/commands labels Jul 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). Needs Design Feedback Needs general design feedback. [Package] Commands /packages/commands [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

No branches or pull requests

1 participant