Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try ordering colors in color variations with body and text colors first #62117

Open
richtabor opened this issue May 29, 2024 · 4 comments · May be fixed by #62548
Open

Try ordering colors in color variations with body and text colors first #62117

richtabor opened this issue May 29, 2024 · 4 comments · May be fixed by #62548
Assignees
Labels
Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json [Status] In Progress Tracking issues with work in progress [Type] Enhancement A suggestion for improvement.

Comments

@richtabor
Copy link
Member

Currently color palette colors are ordered exactly as depicted in a theme variation's JSON file. The challenge here is that it's difficult to parse which palette would be considered a "dark" palette.

For example, in the visual below, the last color palette sets the background of the site to dark green, but it's unclear that it does so, as the variation has more than five colors (the current max colors visible in a palette) and the color used as the background color is not visible in the palette.

A proposal could be to use the color assigned as the body background color first, the color assigned as the body text color second, and then the remaining colors in order up to five.

The result would be what's depicted on the right:

CleanShot 2024-05-29 at 13 47 19

Perhaps not 100% ideal, but there is more clarity. Thoughts?

Related #61215

@richtabor richtabor added the Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json label May 29, 2024
@carolinan
Copy link
Contributor

Its not certain that a theme even sets a background or text color. What happens then?

@richtabor
Copy link
Member Author

Its not certain that a theme even sets a background or text color. What happens then?

If there's not either styles.color.background or styles.color.text colors, then they're omitted and the colors are added per in order—max of five.

@jordesign jordesign added the [Type] Enhancement A suggestion for improvement. label Jun 2, 2024
@luminuu
Copy link
Member

luminuu commented Jun 11, 2024

I touch on this in a video I've made about changes to the style panel: https://youtu.be/U0q0G5wA52U

@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Jun 13, 2024
@justintadlock
Copy link
Contributor

Related: #60478

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json [Status] In Progress Tracking issues with work in progress [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants