Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inserting a new block should scroll to that block #621

Closed
mtias opened this issue May 3, 2017 · 3 comments · Fixed by #752
Closed

Inserting a new block should scroll to that block #621

mtias opened this issue May 3, 2017 · 3 comments · Fixed by #752
Assignees
Labels
[Feature] Inserter The main way to insert blocks using the + button in the editing interface General Interface Parts of the UI which don't fall neatly under other labels. [Priority] High Used to indicate top priority items that need quick attention [Type] Task Issues or PRs that have been broken down into an individual action to take
Milestone

Comments

@mtias
Copy link
Member

mtias commented May 3, 2017

Whenever you insert a new block using the header + button, we ought to scroll to the bottom so the new block is in view.

@mtias mtias added General Interface Parts of the UI which don't fall neatly under other labels. [Feature] Inserter The main way to insert blocks using the + button in the editing interface [Type] Task Issues or PRs that have been broken down into an individual action to take labels May 3, 2017
@mtias mtias added this to the Alpha milestone May 3, 2017
@jasmussen
Copy link
Contributor

Actually shouldn't it insert the block where the caret is?

@mtias
Copy link
Member Author

mtias commented May 3, 2017

Good point. We should focus the viewport on the newly created block, regardless of where it is inserted.

@mtias mtias changed the title Inserting a new block from top toolbar should scroll to bottom Inserting a new block should scroll to that block May 3, 2017
@mtias mtias added the [Priority] High Used to indicate top priority items that need quick attention label May 3, 2017
@mtias mtias modified the milestones: May Week 2, Alpha May 4, 2017
@jasmussen
Copy link
Contributor

See also conversation in #565 (comment)

Current issue: If you insert a text block (any text, including heading, list, etc.), it scrolls to the inserted block. Good! If you insert a block that doesn't have Editable, like embed or image, it doesn't scroll to the block. Let me know if I should ticket this separately.

A thought from @aduth:

It might be that TinyMCE is scrolling the page when it initializes, in which case we should try to disable that default and implement a consistent approach across all blocks.

A comment from @iseulde:

Saw this the other day: https://github.com/tinymce/tinymce-dist/blob/4.6.0/changelog.txt#L6

@youknowriad youknowriad self-assigned this May 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Inserter The main way to insert blocks using the + button in the editing interface General Interface Parts of the UI which don't fall neatly under other labels. [Priority] High Used to indicate top priority items that need quick attention [Type] Task Issues or PRs that have been broken down into an individual action to take
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants