Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move color presets into the palette view #61213

Closed
richtabor opened this issue Apr 29, 2024 · 1 comment · Fixed by #61334
Closed

Move color presets into the palette view #61213

richtabor opened this issue Apr 29, 2024 · 1 comment · Fixed by #61334
Labels
[Feature] Theme Style Variations Related to style variations provided by block themes Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json [Type] Enhancement A suggestion for improvement.

Comments

@richtabor
Copy link
Member

richtabor commented Apr 29, 2024

As a follow-up to #56622, I'd like to propose a bit different experience in order to better support themes with many color presets: moving these presets within the palette control.

These color presets change the palette, which changes the colors applied to elements; they are effectively alternate color palettes.

Why

  • Allows for the experience to scale better for themes that bundle lots of colors.
  • Allows for color presets to render all available colors, giving the user a better understanding of the color palette; not just the body, text, and button colors.
  • Selecting a color preset also resets custom colors (at least currently). You can't tell this is happening in trunk, as custom colors are not visible from this top-level view.

Proposal

color-presets.mp4

Current

Currently we have alternate colors presets listed at the top-level in Styles > Colors. While this works for themes with a few color variations, it does not scale all that well, pushing the palette and elements controls out of the way.

CleanShot 2024-04-29 at 14 29 21

Tasks

  • Change "X colors" to "Edit Palette"
  • Update the "Palette" panel header to match, "Edit Palette"
  • Add improved list of color presets below custom colors.
@richtabor richtabor added [Type] Enhancement A suggestion for improvement. [Feature] Theme Style Variations Related to style variations provided by block themes Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json labels Apr 29, 2024
@richtabor
Copy link
Member Author

richtabor commented Apr 29, 2024

A minor tweak could be to carry the visual language of the color palette options, as rounded options:

CleanShot 2024-04-29 at 14 38 39

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Theme Style Variations Related to style variations provided by block themes Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant