Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update "Link Text" label to "Text" on Social Icons block #60966

Closed
richtabor opened this issue Apr 22, 2024 · 2 comments
Closed

Update "Link Text" label to "Text" on Social Icons block #60966

richtabor opened this issue Apr 22, 2024 · 2 comments
Labels
[Block] Social Affects the Social Block - used to display Social Media accounts [Type] Copy Issues or PRs that need copy editing assistance

Comments

@richtabor
Copy link
Member

As a follow up to #60047, let's update the "Link Text" label to just "Text", which maps consistently to all other link editing controls in the block editor.

Except from original comment: #60047 (comment)

We should not be making inconsistent one-off changes based on much older iterations. I am always on the side of consistency, with a holistic approach to revising. We don't use "Link text" anywhere in the current WordPress editor.

Visual

Current:

CleanShot 2024-04-22 at 10 34 27

As seen in other blocks/UI:

CleanShot 2024-04-22 at 10 35 18

CleanShot 2024-04-22 at 10 35 55
@richtabor richtabor added [Type] Copy Issues or PRs that need copy editing assistance [Block] Social Affects the Social Block - used to display Social Media accounts labels Apr 22, 2024
@richtabor richtabor added this to Polish Apr 22, 2024
@hbhalodia
Copy link
Contributor

Hi @richtabor, I have raised the PR for the same - #61715. Can you please have a look on this PR.

Thank You ✨.

@hbhalodia hbhalodia mentioned this issue May 16, 2024
Merged
@juanfra juanfra moved this to Done in Polish Jul 2, 2024
@juanfra
Copy link
Member

juanfra commented Jul 2, 2024

Closing as completed in #61715

@juanfra juanfra closed this as completed Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[Block] Social Affects the Social Block - used to display Social Media accounts [Type] Copy Issues or PRs that need copy editing assistance
Projects
Polish
Status: Done
Milestone
No milestone
Development

No branches or pull requests
3 participants
@juanfra @richtabor @hbhalodia