Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DataViews: Active page is not highlighted properly in list view. #60708

Closed
youknowriad opened this issue Apr 12, 2024 · 0 comments · Fixed by #62378
Closed

DataViews: Active page is not highlighted properly in list view. #60708

youknowriad opened this issue Apr 12, 2024 · 0 comments · Fixed by #62378
Assignees
Labels
[Feature] DataViews Work surrounding upgrading and evolving views in the site editor and beyond [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended

Comments

@youknowriad
Copy link
Contributor

Description

When you're navigating the the page lists (list view).
you can select pages and they become highlighted,
you can click the "preview" to enter the editor and you can go back to the previous page (two steps through the details page)
But when you're back to the list view, the right page is actually rendered in the preview but it's not highlighted properly in the list.

It seems like we need a "controlled" mode for the selection in the DataViews component (passing the selection as a prop)

Step-by-step reproduction instructions

A quick way to trigger this is to open a url like the following: http://localhost:8888/wp-admin/site-editor.php?postId=2&path=%2Fpage

Screenshots, screen recording, code snippet

Screenshot 2024-04-12 at 2 08 36 PM

Sample page is active on the preview but not on the list view.

Environment info

No response

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes

@youknowriad youknowriad added [Type] Bug An existing feature does not function as intended [Feature] DataViews Work surrounding upgrading and evolving views in the site editor and beyond labels Apr 12, 2024
@jorgefilipecosta jorgefilipecosta self-assigned this Jun 6, 2024
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Jun 6, 2024
@jorgefilipecosta jorgefilipecosta moved this from 📥 Todo to 🏗️ In Progress in WordPress 6.6 Editor Tasks Jun 12, 2024
@jorgefilipecosta jorgefilipecosta moved this from 🏗️ In Progress to 🔎 Needs Review in WordPress 6.6 Editor Tasks Jun 12, 2024
@github-project-automation github-project-automation bot moved this from 🔎 Needs Review to ✅ Done in WordPress 6.6 Editor Tasks Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] DataViews Work surrounding upgrading and evolving views in the site editor and beyond [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants