Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate BlockSelectionButton toolbar #60124

Closed
4 tasks
richtabor opened this issue Mar 22, 2024 · 5 comments
Closed
4 tasks

Consolidate BlockSelectionButton toolbar #60124

richtabor opened this issue Mar 22, 2024 · 5 comments
Labels
[Feature] Zoom Out [Type] Enhancement A suggestion for improvement. [Type] Tracking Issue Tactical breakdown of efforts across the codebase and/or tied to Overview issues.

Comments

@richtabor
Copy link
Member

richtabor commented Mar 22, 2024

We currently have two cases of the BlockSelectionButton toolbar: a variant when select mode is engaged and an alternative when zoom out (#50739) is engaged.

The key difference between both is that select mode enables you to select blocks of any depth, while zoom out (will) enable you to only select the top-level blocks. The experiences are otherwise quite similar across both—and may even end up merging at some point anyhow, so let's consolidate ahead of time.

Tasks

Select mode

In select mode, there is the block icon, drag control, and block name:

CleanShot 2024-03-22 at 12 12 05

Zoom out mode

In zoom out mode (when selecting a top-level block), there is the block icon, mover controls, shuffle icon, block name:

CleanShot 2024-03-22 at 12 13 22

Proposal

Let's have consistent use of block icon, drag, movers, then extra actions—such as shuffling when supported by the block, and a delete control.

CleanShot 2024-03-22 at 12 25 23

It's worth noting that this may become the zoomed-out vertical toolbar for zoomed out mode (and perhaps both, if the modes are combined) (#59737).

@draganescu
Copy link
Contributor

It's worth noting that this may become the zoomed-out vertical toolbar for zoomed out mode

I think this bit makes it so that we should not consolidate.

@richtabor
Copy link
Member Author

I think this bit makes it so that we should not consolidate.

I'm thinking this vertical toolbar may become the only "alternate" toolbar. We don't need the main block toolbar, these two alternates, and a vertical toolbar.

@jeryj
Copy link
Contributor

jeryj commented Mar 26, 2024

For the Select mode, I think we should retain the visible text label. There are a lot of different blocks, and the icons are not always clear as to what the block really is. For the zoom-out mode, are the only blocks available Group and Pattern blocks? If only the outer layer items are there, I think it's less important what the thing is (Group, pattern, etc). This mode seems just for arranging, so only having an icon (or ditching it entirely?) could be warranted.

Let's have consistent use of block icon, drag, movers, then extra actions—such as shuffling when supported by the block, and a #60121.

I agree. Having a consistent order would be great.

The experiences are otherwise quite similar across both—and may even end up merging at some point anyhow, so let's consolidate ahead of time.

I think consolidating the design and interactions of these is a good idea. I don't know if we should technically consolidate them into one component yet though. It may make it harder to maintain and work with, especially early on when we're not sure what all we'll need in Zoom out mode.

@richtabor
Copy link
Member Author

For the Select mode, I think we should retain the visible text label. There are a lot of different blocks, and the icons are not always clear as to what the block really is.

What's the difference between select and edit modes? We don't have text labels on toolbars elsewhere.

This mode seems just for arranging, so only having an icon (or ditching it entirely?) could be warranted.

Yes, I expect it to be more rearranging, shuffling.

@richtabor
Copy link
Member Author

Closing this for now

@richtabor richtabor closed this as not planned Won't fix, can't repro, duplicate, stale Jul 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Zoom Out [Type] Enhancement A suggestion for improvement. [Type] Tracking Issue Tactical breakdown of efforts across the codebase and/or tied to Overview issues.
Projects
None yet
Development

No branches or pull requests

3 participants