Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Social Icons block can't be operated with the keyboard #60120

Closed
afercia opened this issue Mar 22, 2024 · 2 comments · Fixed by #64877
Closed

Social Icons block can't be operated with the keyboard #60120

afercia opened this issue Mar 22, 2024 · 2 comments · Fixed by #64877
Labels
[Block] Social Affects the Social Block - used to display Social Media accounts [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Type] Bug An existing feature does not function as intended

Comments

@afercia
Copy link
Contributor

afercia commented Mar 22, 2024

Description

Discovered while working on #60044 / #60047

After inserting a first social link inside the Social Icons block, I couldn't find a way to add more links when using the keyboard.

Also, focus indication is some of the editing steps is missing.

Step-by-step reproduction instructions

  • Edit a post, add a Social Icons block.
  • At this point, focus is on the empty parent block. Screenshot:

Screenshot 2024-03-22 at 16 02 46

  • Press tab and observe focus moves to the 'Add block' plus icon button. Screenshot:

Screenshot 2024-03-22 at 16 05 51

  • Observe the focus indication is missing.
  • Press Enter and a popover to add social links opens.
  • Select one of the social links and press Enter.
  • The first social link is added. Screenshot:

Screenshot 2024-03-22 at 16 03 24

  • Observe the focus indication is missing.
  • At this point, I couldn't find a way to move focus again to the 'Add block' plus icon button, Tab or Arrows key do different things.
  • The process requires to move focus to the parent block first. This isn't easy with the keyboard but can be done.
  • From there:
    • Tab moves focus to the Settings panel. This is the expected behavior.
    • Arrow keys move focus to the inner blocks, which is the first social link.
    • Couldn't find any way to focus the 'Add block' plus icon button.

Screenshots, screen recording, code snippet

No response

Environment info

No response

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes

@afercia afercia added [Type] Bug An existing feature does not function as intended [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Block] Social Affects the Social Block - used to display Social Media accounts labels Mar 22, 2024
@afercia
Copy link
Contributor Author

afercia commented Mar 25, 2024

The same issue occurs when adding Social links in a Navigation block. I couldn't find a way to mote keyboard focus to the 'plus' icon after adding a first social link:

Screenshot 2024-03-25 at 10 03 02

@Mamaduka
Copy link
Member

@afercia, the #59303 should improve situation a bit by making insert before and after shortcuts available for the inner blocks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Social Affects the Social Block - used to display Social Media accounts [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants