Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bypass the secondary save view if there is only one change #60058

Closed
richtabor opened this issue Mar 20, 2024 · 4 comments · Fixed by #60077
Closed

Bypass the secondary save view if there is only one change #60058

richtabor opened this issue Mar 20, 2024 · 4 comments · Fixed by #60077
Assignees
Labels
[Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") Needs Design Feedback Needs general design feedback. [Status] In Progress Tracking issues with work in progress [Type] Enhancement A suggestion for improvement.

Comments

@richtabor
Copy link
Member

If there's only one "site change", can we bypass the secondary confirm save view in the Site Editor? Currently, you need to press "Save" twice, in every save scenario in the Site Editor. Feels a bit unnecessary.

Visual

CleanShot 2024-03-20 at 18 12 31

@richtabor richtabor added [Type] Enhancement A suggestion for improvement. Needs Design Feedback Needs general design feedback. [Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") labels Mar 20, 2024
@annezazu
Copy link
Contributor

Can we close this out in favor of the following? #38714

@SaxonF
Copy link
Contributor

SaxonF commented Mar 21, 2024

We already do this when using the save button in dark sidebar. It only prompts when you either have more than one entity to save, or you're outside the area that's being saved. I think it makes sense to adopt for editor too, except we should only do it if you're still on the post that has been modified. e.g. If I edit a page, then navigate to another page but don't make an edit, I think we should still prompt.

@richtabor
Copy link
Member Author

Can we close this out in favor of the following? #38714

I can potentially add it as a comment, but we're asking for separate things really. I don't think we need to add an option to consolidate multiple entity saving, but rather be smarter when the confirmation appears (no second step when there's only one entity).

@ntsekouras
Copy link
Contributor

ntsekouras commented Mar 21, 2024

I can potentially add it as a comment, but we're asking for separate things really.

Yes, those are different things. I'll have a PR for this issue soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") Needs Design Feedback Needs general design feedback. [Status] In Progress Tracking issues with work in progress [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants