Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Button: Officially deprecate isSmall prop #59733

Closed
t-hamano opened this issue Mar 10, 2024 · 0 comments · Fixed by #59734
Closed

Button: Officially deprecate isSmall prop #59733

t-hamano opened this issue Mar 10, 2024 · 0 comments · Fixed by #59734
Assignees
Labels
Backwards Compatibility Issues or PRs that impact backwards compatability [Package] Components /packages/components [Type] Enhancement A suggestion for improvement.

Comments

@t-hamano
Copy link
Contributor

#53560 replaced all isSmall props with size="small" in the Gutenberg project. It should be possible to officially deprecate isSmall prop, as indicated by the following comment.

// TODO: Deprecate officially (add console warning and move to DeprecatedButtonProps).
/**
* Decreases the size of the button.
*
* Deprecated in favor of the `size` prop. If both props are defined, the `size` prop will take precedence.
*
* @deprecated Use the `'small'` value on the `size` prop instead.
*/
isSmall?: boolean;

@t-hamano t-hamano added [Type] Enhancement A suggestion for improvement. Backwards Compatibility Issues or PRs that impact backwards compatability [Package] Components /packages/components labels Mar 10, 2024
@t-hamano t-hamano self-assigned this Mar 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Backwards Compatibility Issues or PRs that impact backwards compatability [Package] Components /packages/components [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant