Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gallery Block doesn't apply the 'post_gallery' filter, causing incompatibility with WP Gallery Custom Links #5972

Closed
mrleemon opened this issue Apr 4, 2018 · 3 comments
Closed

Gallery Block doesn't apply the 'post_gallery' filter, causing incompatibility with WP Gallery Custom Links #5972

mrleemon opened this issue Apr 4, 2018 · 3 comments
Labels
Backwards Compatibility Issues or PRs that impact backwards compatability [Block] Gallery Affects the Gallery Block - used to display groups of images [Feature] Media Anything that impacts the experience of managing media Needs Technical Feedback Needs testing from a developer perspective. [Type] Plugin Interoperability Incompatibilities between a specific plugin and the block editor. Close with workaround notes.
Milestone
WordPress 5.0 RC

Comments

@mrleemon
Copy link
Contributor

mrleemon commented Apr 4, 2018

Issue Overview

The WP Gallery Custom Links plugin adds a “Gallery Link URL” field when editing gallery images so users are able to create galleries which link to external resources.

https://es.wordpress.org/plugins/wp-gallery-custom-links/

The plugin continues to work on the backend with Gutenberg active, but links are ignored on the frontend.

Steps to Reproduce (for bugs)

  1. Install the WP Gallery Custom Links plugin and activate it
  2. Add a Gallery block to a post and specify custom URLs in some images
  3. Save the post
  4. View the post

Firefox and Chrome

Expected Behavior

The custom links added to gallery images should appear on the frontend

Current Behavior

The custom links added to the gallery images are not appearing on the frontend, gallery images are not clickable

Possible Solution

Screenshots / Video

Related Issues and/or PRs

Todos
@Soean Soean added the [Type] Plugin Interoperability Incompatibilities between a specific plugin and the block editor. Close with workaround notes. label Apr 4, 2018
@danielbachhuber danielbachhuber added the Backwards Compatibility Issues or PRs that impact backwards compatability label May 18, 2018
@danielbachhuber danielbachhuber added this to the Merge Proposal: Back Compat milestone May 18, 2018
@danielbachhuber
Copy link
Member

danielbachhuber commented May 18, 2018 •
edited
Loading

Related #1451

We need to decide whether Gutenberg needs to support the post_gallery filter, or whether we should expect Gutenberg support for these plugins to be a graceful enhancement.

@danielbachhuber danielbachhuber mentioned this issue May 18, 2018
Closed
@danielbachhuber
Copy link
Member

I've documented this incompatibility in the migration guide.

@danielbachhuber danielbachhuber changed the title WP Gallery Custom Links plugin is not compatible Gallery Block doesn't apply the 'post_gallery' filter, causing incompatibility with WP Gallery Custom Links May 21, 2018
@danielbachhuber danielbachhuber mentioned this issue Jun 5, 2018
Closed
@danielbachhuber danielbachhuber mentioned this issue Jul 18, 2018
Closed
5 tasks
@danielbachhuber danielbachhuber added the [Feature] Media Anything that impacts the experience of managing media label Aug 14, 2018
@markfinst markfinst mentioned this issue Aug 18, 2018
Closed
@mtias mtias removed this from the Merge: Back Compat milestone Oct 3, 2018
@mtias mtias added the Needs Technical Feedback Needs testing from a developer perspective. label Oct 3, 2018
@mtias mtias added this to the WordPress 5.0 milestone Oct 3, 2018
@Soean Soean added the [Block] Gallery Affects the Gallery Block - used to display groups of images label Oct 26, 2018
@antpb
Copy link
Contributor

antpb commented Oct 26, 2018

Going to close as discussed in the recent core-media meeting in favor of keeping things focused on #1451

Support for the post_gallery filter will be solved with a fallback to the gallery shortcode.

@antpb antpb closed this as completed Oct 26, 2018
@mcsf mcsf mentioned this issue Nov 6, 2018
Closed
@tyrann0us tyrann0us mentioned this issue Feb 11, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Backwards Compatibility Issues or PRs that impact backwards compatability [Block] Gallery Affects the Gallery Block - used to display groups of images [Feature] Media Anything that impacts the experience of managing media Needs Technical Feedback Needs testing from a developer perspective. [Type] Plugin Interoperability Incompatibilities between a specific plugin and the block editor. Close with workaround notes.
Projects
None yet
Milestone
WordPress 5.0 RC
Development

No branches or pull requests
5 participants
@danielbachhuber @mtias @Soean @mrleemon @antpb