Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate the 'Additional CSS Class' setting #5884

Closed
DannyCooper opened this issue Mar 29, 2018 · 4 comments
Closed

Separate the 'Additional CSS Class' setting #5884

DannyCooper opened this issue Mar 29, 2018 · 4 comments
Labels
[Feature] Blocks Overall functionality of blocks Needs Dev Ready for, and needs developer efforts

Comments

@DannyCooper
Copy link
Contributor

Has it been considered to visually separate the 'Additional CSS Class' setting from the above Panel? By default, it could be mistaken as part of the previous panel.

Current:
image

Idea:
image

I'm happy to provide a pull request if needed.

Thanks!

@aduth aduth added the Design label Mar 29, 2018
@gziolo
Copy link
Member

gziolo commented Mar 29, 2018

There is closed PR which does something similar by grouping such settings. I can bring it back to life and update if we agree to introduce visual changes as proposed.

@karmatosed
Copy link
Member

I would +1 bringing that back to life @gziolo and adding this in. It feels like a simple improvement but useful one. Thanks for noting this @DannyCooper.

@karmatosed karmatosed added [Feature] Blocks Overall functionality of blocks Needs Dev Ready for, and needs developer efforts and removed Design labels Apr 1, 2018
@mtias
Copy link
Member

mtias commented Apr 2, 2018

It was supposed to be inside an "Advanced Settings" panel, together with "anchor" setting.

@gziolo
Copy link
Member

gziolo commented Apr 3, 2018

I opened #5952 to address it, which is based on #3475. It still misses some inline docs but I'd like to get feedback if the UI part looks as expected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Blocks Overall functionality of blocks Needs Dev Ready for, and needs developer efforts
Projects
None yet
Development

No branches or pull requests

5 participants