Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shadow: Follow up to address feedback. #58298

Closed
6 tasks done
madhusudhand opened this issue Jan 26, 2024 · 6 comments
Closed
6 tasks done

Shadow: Follow up to address feedback. #58298

madhusudhand opened this issue Jan 26, 2024 · 6 comments
Assignees
Labels
Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json [Type] Enhancement A suggestion for improvement.

Comments

@madhusudhand
Copy link
Member

madhusudhand commented Jan 26, 2024

This issue is a followup for #57101.

@madhusudhand madhusudhand self-assigned this Jan 26, 2024
@madhusudhand madhusudhand changed the title Shadow: Follow up to address the feedback. Shadow: Follow up to address feedback. Jan 26, 2024
@madhusudhand
Copy link
Member Author

Default presets are opted-in by default - change to only show if theme opts in?

@mtias
Default presets were already enabled by default in the previous release for button in global styles.
Changing the behaviour now might break themes that use shadow for button.

Move shadow out of Effects panel and possibility keep it under Border.

@jasmussen could you provide updated designs.

@jasmussen
Copy link
Contributor

Yep, I'll update a sketch when I have a moment. For now, though, the idea is to just rename the current panel called "Border", call it "Border & Shadow", and move the control to the bottom of that panel.

@jordesign jordesign added [Type] Enhancement A suggestion for improvement. Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json labels Jan 28, 2024
@jasmussen
Copy link
Contributor

Found these:

Shadows in the inspector Shadows in Global Styles

The panel title can be contextual, when a block only supports border, call it "Border", if a block only supports shadow, call it "Shadow", when it supports both, call it "Border & Shadow".

@richtabor
Copy link
Member

Should we introduce without core presets enabled? As there are no controls

This first iteration does not include the ability to create shadows, so if there are no presets, you should not be able to have the control available. When we do follow-up with shadow creation, then yes, it should be available as an option to apply.

@richtabor
Copy link
Member

Default presets are opted-in by default - change to only show if theme opts in?

I would expect shadow presets to work like other default presets—defaultDuotone, defaultPalette, defaultGradients, etc.

@madhusudhand
Copy link
Member Author

Closing as all feedback items are complete.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

No branches or pull requests

4 participants