Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PaletteEdit: Cannot edit or rename color by keyboard #58188

Closed
mirka opened this issue Jan 24, 2024 · 1 comment
Closed

PaletteEdit: Cannot edit or rename color by keyboard #58188

mirka opened this issue Jan 24, 2024 · 1 comment
Assignees
@DaniGuardiola
Labels
[Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Package] Components /packages/components [Type] Bug An existing feature does not function as intended

Comments

@mirka
Copy link
Member

mirka commented Jan 24, 2024

The ColorPicker popover has a focus trap, and does not close on Esc in certain cases, making it impossible to exit out of the popover by keyboard.

Reproduction steps (by keyboard)

  1. Click the "Add color" button.
  2. Focus is moved to the ColorPicker popover, and is stuck.
CleanShot.2024-01-24.at.22.34.28.mp4

Same thing happens when you go to the "Color options dropdown menu ▸ Show details" and choose a color to edit. You are stuck in a popover and cannot edit color values or names.

Proposed fix

The ColorPicker popover should close on Esc.
@mirka mirka added [Type] Bug An existing feature does not function as intended [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Package] Components /packages/components labels Jan 24, 2024
@mirka mirka mentioned this issue Jan 24, 2024
Merged
@mirka mirka mentioned this issue Feb 15, 2024
Merged
@DaniGuardiola DaniGuardiola self-assigned this May 6, 2024
@mirka
Copy link
Member Author

mirka commented Jun 26, 2024

Fixed by #62753

@mirka mirka closed this as completed Jun 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DaniGuardiola DaniGuardiola

Labels
[Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Package] Components /packages/components [Type] Bug An existing feature does not function as intended
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mirka @DaniGuardiola