Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Font Library: Google Font have more Option Select and install all #58011

Closed
Tracked by #60528
ghorivipul97 opened this issue Jan 19, 2024 · 2 comments · Fixed by #63893
Closed
Tracked by #60528

Font Library: Google Font have more Option Select and install all #58011

ghorivipul97 opened this issue Jan 19, 2024 · 2 comments · Fixed by #63893
Assignees
Labels
[Feature] Font Library [Feature] Typography Font and typography-related issues and PRs [Status] In Progress Tracking issues with work in progress [Type] Enhancement A suggestion for improvement.

Comments

@ghorivipul97
Copy link
Contributor

What problem does this address?

if we have more then 1 variation then hard to select one by one checkbox.

What is your proposed solution?

User able to Select & Install All Font
image

@ghorivipul97 ghorivipul97 added the [Type] Enhancement A suggestion for improvement. label Jan 19, 2024
@colorful-tones colorful-tones added [Feature] Typography Font and typography-related issues and PRs [Feature] Font Library labels Jan 20, 2024
@creativecoder
Copy link
Contributor

There's a performance consideration here that's worth considering when looking at the UI design--generally it's best to select only the variants you plan to use and not just install all of them, since loading a lot of fonts on the front-end of the site can add to overall loading time.

Personally I'd argue against including an install/select all button when installing fonts to encourage selecting only what's needed.

@jasmussen
Copy link
Contributor

There's a duplicated issue here, where @creativecoder graciously responded to my inquiry on what performance issue specifically was at play:

So selecting all the variants of a font doesn't cause a performance problem by itself--it's one extra line of html added to the page for each variant. The performance issue comes if all the variants are available, and the styles settings on a page call for loading all of them (e.g. you've picked lots of similar but different weights in the styles settings for blocks that load on the page).

Ah, thanks for clarifying. But to me that's even more an argument for allowing the "select all" checkbox, and instead potentially show a warning notice if you're using too many fonts in a page, can be in pre-publish, can be in the typography panel, can be a snackbar, etc.

Adding the "select all" checkbox is not just about the ergonomics of not having to click upwards of 20 times for some of the bigger font families (I wouldn't want to click that many times if I'm motor impaired!) It's also about recognizing this same data view pattern as it's being applied across the data views work for pages, templates, etc:
screenshot of page table in the site editor

By omitting the checkbox, we're not protecting you from using too many fonts, or even warning that it's bad. We're just creating an interface that requires more clicks, and which diverges from the list view work that is ongoing.

I'd love to see this added, in other words 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Font Library [Feature] Typography Font and typography-related issues and PRs [Status] In Progress Tracking issues with work in progress [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants