Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ToggleGroupControl: Add disabled state #57862

Open
mirka opened this issue Jan 15, 2024 · 3 comments · Fixed by #63450
Open

ToggleGroupControl: Add disabled state #57862

mirka opened this issue Jan 15, 2024 · 3 comments · Fixed by #63450
Labels
[Package] Components /packages/components [Type] Enhancement A suggestion for improvement.

Comments

@mirka
Copy link
Member

mirka commented Jan 15, 2024

What problem does this address?

#57562 surfaced a use case for a disabled state for ToggleGroupControl.

What is your proposed solution?

  • The styling could be similar to the isPressed Button component when it is disabled.
  • As for the focus behavior when disabled, we may need an additional focusableWhenDisabled prop on ToggleGroupControl so consumers can choose.
@mirka mirka added the [Type] Enhancement A suggestion for improvement. label Jan 15, 2024
@mirka mirka added the [Package] Components /packages/components label Jan 15, 2024
@ciampo
Copy link
Contributor

ciampo commented Jan 16, 2024

we may need an additional focusableWhenDisabled prop on ToggleGroupControl so consumers can choose.

We should probably keep an eye on the final decision made in #56547, so that we can ensure consistency in the prop naming and (potentially) default behaivior

@mirka
Copy link
Member Author

mirka commented Jul 16, 2024

@ciampo I accidentally confounded the two at first too, but this issue is for a disabled state on the entire component, not the individual options. This was the use case in BorderControl (#57562), where ideally I wanted to disable the entire ToggleGroupControl and maybe show a tooltip to explain why it was disabled.

@mirka mirka reopened this Jul 16, 2024
@ciampo
Copy link
Contributor

ciampo commented Jul 16, 2024

Got it! Let me know if you think it's worth working on it soon, while we're still fresh from other ToggleGroupControl work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Package] Components /packages/components [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants