Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Site icon image in the Site editor doesn't update on the fly #57847

Open
afercia opened this issue Jan 15, 2024 · 0 comments
Open

Site icon image in the Site editor doesn't update on the fly #57847

afercia opened this issue Jan 15, 2024 · 0 comments
Labels
[Package] Edit Site /packages/edit-site [Type] Bug An existing feature does not function as intended

Comments

@afercia
Copy link
Contributor

afercia commented Jan 15, 2024

Description

In the Site editor, when setting the Site logo block image to be used also as a Site Icon, the image is supposed to replace the WP logo used in the 'Open Navigation' control at the top left of the editor UI.
I would expect the image to update on the fly when it is set, replaced, or removed. It doesn't update. As such, the editor UI may show two different images for the Site logo and Site icon which feels confusing for users. Example screenshot:

Screenshot 2024-01-15 at 12 42 50

I'm not even sure using the Site Icon image in the editor UI is a good idea in the first palce, for the considerations made on #57813. However, if keeping using it is the desired behavior, it should work as expected.

Step-by-step reproduction instructions

  • Go to the Site Editor > Edit mode.
  • Select the Site Logo block in the header or add one.
  • Add a Site logo image.
  • Check 'Use as site icon' in the settings panel.
  • Save.
  • Observe the image shown in the 'Open Navigation' (which is supposed to be the Site Icon) doesn't update.
  • Refresh the page.
  • Observe the image shown in the 'Open Navigation' is now the one you set as Site icon.
  • Select the Site Logo block in the header.
  • Replace the Site Logo image with another one.
  • Save.
  • Observe that while the Site Logo block image does update, the Site Icon image does not.
  • Refresh the page.
  • Observe the Site Icon image now the new one.
  • Select the Site Logo block in the header.
  • Uncheck 'Use as site icon'.
  • Save.
  • Observe the Site Icon image doesn't update. Expected: the image to revert to the default WP logo.
  • Check again 'Use as site icon'.
  • Save.
  • Select the Site Logo block in the header.
  • Open the 'Media' dropdown in the Settings panel and click 'Reset'.
  • Save.
  • Observe that while the Site Logo block image gets removed, the Site icon stays.
  • Refresh the page.
  • Observe the Site Icon image is now back to the default WP logo.

Screenshots, screen recording, code snippet

No response

Environment info

No response

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes

@afercia afercia added [Type] Bug An existing feature does not function as intended [Package] Edit Site /packages/edit-site labels Jan 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Package] Edit Site /packages/edit-site [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

No branches or pull requests

1 participant