Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the position and size of the Options menu across the editors #57514

Closed
afercia opened this issue Jan 3, 2024 · 0 comments · Fixed by #57515
Closed

Fix the position and size of the Options menu across the editors #57514

afercia opened this issue Jan 3, 2024 · 0 comments · Fixed by #57515
Assignees
Labels
[Package] Edit Post /packages/edit-post [Package] Edit Site /packages/edit-site [Package] Interface /packages/interface [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended

Comments

@afercia
Copy link
Contributor

afercia commented Jan 3, 2024

Description

The position and size of the Options menu across the editors is inconsistent:

  1. The spacing from the right edge of the screen is different. The root cause is the different right padding applied to the container of the More button that opens the menu. Improve button spacing in the top right corner of the editor #40411 standardized this padding but then Clean up header toolbar metrics and responsive break points #56729 changed it again only in the Site editor. Also, the post editor changes this padding for small screens while the site editor doesn't.
  2. The actual width of the menu depends on its content. It's a flexible width between 280 and 480 pixels. In the two editors the menu content is different. As such, the menu width differs. To me, visual consistency is more important than trying to accomodate width based on the content. I think there's two options here:
  • Either enlarge a bit the width: there's no apparent reason why the minimum width must be 280 pixels. That's the width of the sidebars but this menu doesn't need to look like a sidebar.
  • Make it have ea fixed width.

Step-by-step reproduction instructions

  • Compare the Options menu in the Post editor and in the Site editor.
  • Observe the spacing from the right edge of the screen is different by 2 pixels.
  • Observe the position of the More button (the ellipsis) is different in the first place.
  • Observe the width of the menu is different.

Screenshots, screen recording, code snippet

Screenshot: Options menu in the Post editor and in the Site editor:

Screenshot 2024-01-03 at 09 58 56

Environment info

No response

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes

@afercia afercia added [Type] Bug An existing feature does not function as intended [Package] Edit Post /packages/edit-post [Package] Interface /packages/interface [Package] Edit Site /packages/edit-site labels Jan 3, 2024
@afercia afercia self-assigned this Jan 3, 2024
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Jan 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Package] Edit Post /packages/edit-post [Package] Edit Site /packages/edit-site [Package] Interface /packages/interface [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant