Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish button shows unnecessary tooltip #56755

Closed
afercia opened this issue Dec 4, 2023 · 1 comment · Fixed by #56759
Closed

Publish button shows unnecessary tooltip #56755

afercia opened this issue Dec 4, 2023 · 1 comment · Fixed by #56759
Assignees
Labels
[Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Package] Editor /packages/editor [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended

Comments

@afercia
Copy link
Contributor

afercia commented Dec 4, 2023

Description

Noticed while working on #56214

The Publish button in the settings sidebar may show a tooltip that just repeats the visible text in the button. The button used to truncate the visible text (at least in the Site editor). It was recently changed to show the full date / time so that the tooltip seems unnecessary now and it just clutters the UI.
See #56319 and #56196

However, when the Timezone setting is set to the user actual time zone, the visible text is a shorter version of the expansion shown in the tooltip. Only when the Timezone setting is different, the visible text and the tooltip text are the same.

Screenshots:

Screenshot 2023-12-04 at 14 15 09

Screenshot 2023-12-04 at 14 24 19

Step-by-step reproduction instructions

  • Go to the WordPress admin, Settings > General Settings > Timezone.
  • Set the Timezone value to a value other than your actual time zone.
  • Edit a post.
  • Hover the publish date button.
  • Observe the tooltip just repeats the visible text.
  • Go to the WordPress admin, Settings > General Settings > Timezone.
  • Set the Timezone value to your actual time zone.
  • Edit a post.
  • Hover the publish date button.
  • Observe the tooltip contains more information than the visible text.

Screenshots, screen recording, code snippet

No response

Environment info

No response

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes

@afercia afercia added [Type] Bug An existing feature does not function as intended [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Package] Editor /packages/editor labels Dec 4, 2023
@afercia
Copy link
Contributor Author

afercia commented Dec 4, 2023

Worth reminding special cases like the 'Immediately' string that needs expansion and the 'same day' date case. E.g.:

Screenshot 2023-12-04 at 14 45 59

Anyways, when the visible text and the tooltip text are the same, the tooltip should not be used.

@afercia afercia self-assigned this Dec 4, 2023
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Dec 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Package] Editor /packages/editor [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant