Align data view icon usage #56602
Merged
Align data view icon usage #56602
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jameskoster
added
[Type] Bug
|
Size Change: -254 B (0%) Total Size: 1.72 MB
ℹ️ View Unchanged
|
This was referenced Nov 30, 2023
derekblank
pushed a commit
that referenced
this pull request
Dec 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Update icon usage in data view UIs.
Why?
In data views, the icon used in menu items and the View options button are supposed to reflect the layout associated with each view. There are some inconsistencies in the current implementation that break that intended alignment:
blockTablegridcolumnspagecolumnscolumnsThis PR updates each element to use the following icons:
formatListBulletscategorycolumnsformatListBulletscategorycolumnsBefore
After
Testing Instructions
Caveat
formatListBulletsis by no means the perfect icon for the list layout. However, we probably need a new icon for this use case, one that potentially harmonises better withcategory. I intend to explore that in a dedicated follow up, this PR is purely about ensuring consistent behavior between these related UI elements.