Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom data views: Offer a dedicated way to save changes #56205

Open
jameskoster opened this issue Nov 16, 2023 · 1 comment
Open

Custom data views: Offer a dedicated way to save changes #56205

jameskoster opened this issue Nov 16, 2023 · 1 comment
Labels
[Feature] DataViews Work surrounding upgrading and evolving views in the site editor and beyond Needs Design Feedback Needs general design feedback. [Type] Enhancement A suggestion for improvement.

Comments

@jameskoster
Copy link
Contributor

Saving changes to a custom data view is currently batched together with changes to the site itself:

Screenshot 2023-11-16 at 13 27 50

When initially creating the view this level of gravity is perhaps warranted. However, when you're temporarily adjusting an existing view it feels a bit heavy-handed. Generally these are 'softer' edits that you wouldn't expect to persist. For example when you view Trash in wp-admin the date filter is inactive, regardless of whether you previously filtered by date or not.

We might consider the following adjustments to the save flow for custom views;

  1. Including a "Save" action in the view menu.
  2. Indicating the view has been customised somehow.
  3. Not alerting the user of unsaved changes when navigating away.

A rough mockup:

Screenshot 2023-11-16 at 13 53 52

cc @WordPress/gutenberg-design

@jameskoster jameskoster added [Type] Enhancement A suggestion for improvement. Needs Design Feedback Needs general design feedback. [Feature] DataViews Work surrounding upgrading and evolving views in the site editor and beyond labels Nov 16, 2023
@jasmussen
Copy link
Contributor

Good issue.

The custom views, at the moment, feel a bit like an open question to me; I think they hold great potential long term, especially with just the right UI (for pinning, unpinning, deleting, moving, user role management, plugin management, all sorts of other things to explore), so I wonder if this nascent time is the right time to explore optimizations for the current set of features. I'd almost be tempted to keep the custom view aspect plugin only for a while still, until we have a solid path forward for these concepts.

@oandregal oandregal mentioned this issue Apr 16, 2024
37 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] DataViews Work surrounding upgrading and evolving views in the site editor and beyond Needs Design Feedback Needs general design feedback. [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

No branches or pull requests

2 participants