-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HTML Block: Toggle syntax highlighting #5614
Comments
I think a per-block toggle would probably be frustrating, as you'd get tired of having to flip it for every new block you inserted. It seems a more global toggle would be better. Should such a toggle live in the More menu, perhaps under the "Fix toolbar to block" toggle? |
I wouldn't mind it existing in the HTML Block inspector control (which is empty, and the first place I'd look) but being a global setting. (We can clarify that in the toggle.) |
I kind of like it in the more menu. |
Please can you explain this requirement. There is already a user level field labelled Syntax Highlighting which is used to control whether or not syntax is highlighted in the Customiser > Additional CSS and the Custom HTML Widget.
|
I noticed that when I toggled the Syntax Highlighting option off that the Custom HTML block editor fails to render entirely. |
Adding the accessibility label and 5.0 milestone as this is strictly related to #5467 that's already milestoned for 5.0. |
Any chance to integrate this as a "global" option based on the existing user preference "Disable syntax highlighting when editing code"? |
Discussed during today's accessibility bug-scrub and agreed ideally it should be based on the existing user option. @aldavigdis also proposed to consider a "global" option for administrator who might want to disable it by default for all users, and users allowed to override the default. |
Just a soft suggestion. Putting things out in the ether. |
Pushing this to future versions as we have disabled syntax highlighting by default on this block, which is a better baseline at the moment. |
Add a toggle to disable syntax highlighting in the inspector:
Considerations
Should this be a per-block settings or user setting? I feel if I want to disable syntax highlighting I'd appreciate it being disabled across the board.
cc @jasmussen
The text was updated successfully, but these errors were encountered: