HTML Block: Toggle syntax highlighting

[mtias]

Add a toggle to disable syntax highlighting in the inspector:

Considerations

Should this be a per-block settings or user setting? I feel if I want to disable syntax highlighting I'd appreciate it being disabled across the board.

cc @jasmussen

[jasmussen]

I feel if I want to disable syntax highlighting I'd appreciate it being disabled across the board.

I think a per-block toggle would probably be frustrating, as you'd get tired of having to flip it for every new block you inserted. It seems a more global toggle would be better.

Should such a toggle live in the More menu, perhaps under the "Fix toolbar to block" toggle?

[mtias]

Should such a toggle live in the More menu, perhaps under the "Fix toolbar to block" toggle?

I wouldn't mind it existing in the HTML Block inspector control (which is empty, and the first place I'd look) but being a global setting. (We can clarify that in the toggle.)

[karmatosed]

Should such a toggle live in the More menu, perhaps under the "Fix toolbar to block" toggle?

I kind of like it in the more menu.

[bobbingwide]

Please can you explain this requirement.

There is already a user level field labelled Syntax Highlighting which is used to control whether or not syntax is highlighted in the Customiser > Additional CSS and the Custom HTML Widget.

• Is this the same thing?
• If so, what are the requirements and what is the proposed solution?
• If not, why not?
• What relation, if any, does this have to Andrea's comments on usability of the custom HTML block? Custom HTML block experience much like Groundhog Day #5467 (comment)

[westonruter]

I noticed that when I toggled the Syntax Highlighting option off that the Custom HTML block editor fails to render entirely.

[afercia]

Adding the accessibility label and 5.0 milestone as this is strictly related to #5467 that's already milestoned for 5.0.

[afercia]

Any chance to integrate this as a "global" option based on the existing user preference "Disable syntax highlighting when editing code"?

[afercia]

Discussed during today's accessibility bug-scrub and agreed ideally it should be based on the existing user option.

@aldavigdis also proposed to consider a "global" option for administrator who might want to disable it by default for all users, and users allowed to override the default.

[aldavigdis]

Just a soft suggestion. Putting things out in the ether.

[mtias]

Pushing this to future versions as we have disabled syntax highlighting by default on this block, which is a better baseline at the moment.