Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Image: Update lightbox full screen icon #55462

Closed
artemiomorales opened this issue Oct 18, 2023 · 0 comments · Fixed by #55463
Closed

Image: Update lightbox full screen icon #55462

artemiomorales opened this issue Oct 18, 2023 · 0 comments · Fixed by #55463
Labels
[Block] Image Affects the Image Block [Type] Enhancement A suggestion for improvement.

Comments

@artemiomorales
Copy link
Contributor

artemiomorales commented Oct 18, 2023 •
edited
Loading

What problem does this address?

The full screen icon was recently updated in #55021, but the lightbox does not use it.

What is your proposed solution?

Revise the code for the full screen button, introduced in #55212, to use the new icon.
@artemiomorales artemiomorales added [Block] Image Affects the Image Block [Type] Bug An existing feature does not function as intended labels Oct 18, 2023
@artemiomorales artemiomorales mentioned this issue Oct 18, 2023
Merged
@artemiomorales artemiomorales linked a pull request Oct 18, 2023 that will close this issue
Image: Update default fullscreen icon for lightbox trigger #55463
Merged
@artemiomorales artemiomorales mentioned this issue Oct 18, 2023
Open
69 tasks
@jordesign jordesign added [Type] Enhancement A suggestion for improvement. and removed [Type] Bug An existing feature does not function as intended labels Oct 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[Block] Image Affects the Image Block [Type] Enhancement A suggestion for improvement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Image: Update default fullscreen icon for lightbox trigger WordPress/gutenberg
2 participants
@jordesign @artemiomorales