Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

List: block alignment controls should work #548

Closed
mtias opened this issue Apr 28, 2017 · 4 comments
Closed

List: block alignment controls should work #548

mtias opened this issue Apr 28, 2017 · 4 comments
Assignees
Labels
[Feature] Blocks Overall functionality of blocks [Type] Task Issues or PRs that have been broken down into an individual action to take
Milestone

Comments

@mtias
Copy link
Member

mtias commented Apr 28, 2017

Hook up the styles for the alignment controls on lists.

@mtias mtias added [Feature] Blocks Overall functionality of blocks [Type] Task Issues or PRs that have been broken down into an individual action to take labels Apr 28, 2017
@mtias mtias added this to the Prototype Parity milestone Apr 28, 2017
@mtias mtias modified the milestones: May Week 1, Prototype Parity May 1, 2017
@BE-Webdesign BE-Webdesign self-assigned this May 2, 2017
@BE-Webdesign
Copy link
Contributor

As far as I can tell, this already works. Whenever it is left aligned, there is no style attribute added, but the other alignments appear to work properly. This behavior matches the text block.

@joyously
Copy link

joyously commented May 2, 2017

Does defaulting to left align doing nothing make it more difficult to handle RTL later?

@jasmussen
Copy link
Contributor

As far as I can tell, this already works. Whenever it is left aligned, there is no style attribute added, but the other alignments appear to work properly. This behavior matches the text block.

Just tried it again, and yes this works now. When we did a review of the editor it did not work, for some reason.

There are still some iffy selection focus features, and a justify button. But these are tracked separately in #567 and #540

@BE-Webdesign
Copy link
Contributor

@joyously

That is a great point to bring up and if there is not already open an issue up for RTL support, you should open one. That is something we don't want to skip over.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Blocks Overall functionality of blocks [Type] Task Issues or PRs that have been broken down into an individual action to take
Projects
None yet
Development

No branches or pull requests

4 participants