Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UseOnce block does not get unlocked after transform #5471

Closed
hedgefield opened this issue Mar 7, 2018 · 2 comments
Closed

UseOnce block does not get unlocked after transform #5471

hedgefield opened this issue Mar 7, 2018 · 2 comments
Assignees
Labels
[Type] Bug An existing feature does not function as intended

Comments

@hedgefield
Copy link

hedgefield commented Mar 7, 2018

Issue Overview

Converting a locked UseOnce block to another block type does not remove the lock.

tim

Steps to Reproduce (for bugs)

  1. Add a subhead block.
  2. Add another subhead block, this gets locked for violating UseOnce so to speak.
  3. Use the block switcher to switch the locked subhead block to a paragraph block.
  4. Now the error says "Paragraph cannot be used twice".

Chrome with WP 4.9.4 vagrant and Gutenberg 2.3.0.

Expected Behavior

The lock to be lifted after an acceptable transformation has been made (as in, to a block that does not trigger UseOnce).

Current Behavior

UseOnce is enforced until the block is deleted.

@jeffpaul jeffpaul added the [Type] Bug An existing feature does not function as intended label Mar 8, 2018
@mcsf mcsf self-assigned this Mar 11, 2018
@mcsf
Copy link
Contributor

mcsf commented Mar 15, 2018

@hedgefield, I was circling back to this one. Can you still repro?

@hedgefield
Copy link
Author

Nope, it's fixed in 2.4! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Bug An existing feature does not function as intended
Projects
None yet
Development

No branches or pull requests

3 participants