Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Patterns: no user categories in Inserter & automatically listed as both "all categories" and uncategorized #54616

Closed
annezazu opened this issue Sep 19, 2023 · 3 comments · Fixed by #54641
Closed

Patterns: no user categories in Inserter & automatically listed as both "all categories" and uncategorized #54616

annezazu opened this issue Sep 19, 2023 · 3 comments · Fixed by #54641
Assignees
@aaronrobertshaw
Labels
[Feature] Patterns A collection of blocks that can be synced (previously reusable blocks) or unsynced [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended

Comments

@annezazu
Copy link
Contributor

Using Gutenberg nightly from the last 24 hours, I noticed that despite creating different categories for two patterns, they do not show up in the Inserter and, for some reason, appear as "uncategorized". This stand in contrast to this PR: #53933 @glendaviesnz

To replicate, create a few patterns and set different categories. Try then to add those to a template or page from the Inserter and notice the categories don't appear:

no.user.categories.for.patterns.in.inserter.mov
@annezazu annezazu added the [Type] Bug An existing feature does not function as intended label Sep 19, 2023
@skorasaurus skorasaurus added [Feature] Patterns A collection of blocks that can be synced (previously reusable blocks) or unsynced [Type] Regression Related to a regression in the latest release labels Sep 19, 2023
@annezazu annezazu moved this to Needs Dev / Todo in WordPress 6.4 Editor Tasks Sep 19, 2023
@aaronrobertshaw aaronrobertshaw removed the [Type] Regression Related to a regression in the latest release label Sep 20, 2023
@aaronrobertshaw
Copy link
Contributor

After some further testing, I found the following:

  • Issue can be replicated in the site editor
  • Works in the post editor
  • Custom user categories have been missing in the site editor's inspector since #53835 merged

@aaronrobertshaw aaronrobertshaw mentioned this issue Sep 20, 2023
Merged
@aaronrobertshaw
Copy link
Contributor

A fix is up for review in #54641

@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Sep 20, 2023
@github-project-automation github-project-automation bot moved this from Needs Dev / Todo to Done in WordPress 6.4 Editor Tasks Sep 20, 2023
@annezazu
Copy link
Contributor Author

Boom! You all are speedy :) Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aaronrobertshaw aaronrobertshaw

Labels
[Feature] Patterns A collection of blocks that can be synced (previously reusable blocks) or unsynced [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended
Projects
No open projects
WordPress 6.4 Editor Tasks
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Patterns: Fix user pattern categories in site editor inserter WordPress/gutenberg
3 participants
@skorasaurus @annezazu @aaronrobertshaw