Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link Control overlap Button block toolbar if post edit page includes legacy metaboxes #54383

Closed
shvlv opened this issue Sep 12, 2023 · 4 comments
Labels
Needs Testing Needs further testing to be confirmed. [Status] Stale Gives the original author opportunity to update before closing. Can be reopened as needed. [Type] Bug An existing feature does not function as intended

Comments

@shvlv
Copy link
Contributor

shvlv commented Sep 12, 2023

Description

I expect the Button toolbar should work regardless Button block place. But the Button block toolbar becomes unusable if the button is placed at the bottom of the page editor with legacy metaboxes.

As far I can see the main problem is 40vh padding bottom available for pages without legacy metaboxes only.

Step-by-step reproduction instructions

  1. Install any plugin providing legacy meta boxes.
  2. Create a new page and start editing.
  3. Fill content equals browser screen height.
  4. Insert Button button.
  5. Using Link Control add URL.

Screenshots, screen recording, code snippet

The expected behavior (without metaboxes):

image

The buggy behavior (with any metabox enabled):

image

Environment info

  • WordPress 6.3.1, without Gutenberg plugin, Twenty Twenty-Three 1.2
  • Yoast SEO Version 21.1 (as metabox example)
  • Browser Google Chrome Version 115.0.5790.170 (Official Build) (64-bit)
  • Linux Desktop

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes

@karmatosed karmatosed added Needs Testing Needs further testing to be confirmed. [Type] Bug An existing feature does not function as intended labels Sep 13, 2023
@github-actions
Copy link

Hi,
This issue has gone 30 days without any activity. This means it is time for a check-in to make sure it is still relevant. If you are still experiencing this issue with the latest versions, you can help the project by responding to confirm the problem and by providing any updated reproduction steps.
Thanks for helping out.

@github-actions github-actions bot added the [Status] Stale Gives the original author opportunity to update before closing. Can be reopened as needed. label Oct 14, 2023
@shvlv
Copy link
Contributor Author

shvlv commented Jun 5, 2024

The issue was fixed, in version 16.8 at least. Perhaps, it's the result of #54286.

@shvlv shvlv closed this as completed Jun 5, 2024
@shvlv
Copy link
Contributor Author

shvlv commented Aug 28, 2024

The issue came back with the new WordPress release:

link-control-metabox.webm

@shvlv shvlv reopened this Aug 28, 2024
@shvlv
Copy link
Contributor Author

shvlv commented Aug 30, 2024

It's a duplicate of #63882. And it was fixed last week with #64639. Controls work as expected now:

image

@shvlv shvlv closed this as completed Aug 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Testing Needs further testing to be confirmed. [Status] Stale Gives the original author opportunity to update before closing. Can be reopened as needed. [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

No branches or pull requests

2 participants