Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Quick pattern inserter doesn't include synced patterns or template parts #54180

Closed
jameskoster opened this issue Sep 5, 2023 · 2 comments
Closed

Quick pattern inserter doesn't include synced patterns or template parts #54180

jameskoster opened this issue Sep 5, 2023 · 2 comments
Labels
[Feature] Patterns A collection of blocks that can be synced (previously reusable blocks) or unsynced [Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") [Feature] Synced Patterns Related to synced patterns (formerly reusable blocks) [Type] Bug An existing feature does not function as intended

Comments

@jameskoster
Copy link
Contributor

When editing a template in the Site Editor, if the quick inserter is invoked from the document root it will display patterns:

Screenshot 2023-09-05 at 10 02 40

However this only seems to include unsynced patterns. It's not possible to view synced patterns or template parts here – even when searching – which seems like an oversight.
@jameskoster jameskoster added [Type] Bug An existing feature does not function as intended [Feature] Synced Patterns Related to synced patterns (formerly reusable blocks) [Feature] Patterns A collection of blocks that can be synced (previously reusable blocks) or unsynced [Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") labels Sep 5, 2023
@aaronrobertshaw aaronrobertshaw moved this to Todo in Patterns Sep 6, 2023
@bph bph moved this to Triage in WordPress 6.4 Editor Tasks Sep 6, 2023
@aaronrobertshaw aaronrobertshaw moved this from Todo to Needs Design in Patterns Sep 7, 2023
@aaronrobertshaw aaronrobertshaw moved this from Needs Design to Todo in Patterns Sep 7, 2023
@aaronrobertshaw aaronrobertshaw moved this from Todo to In Progress in Patterns Sep 7, 2023
@glendaviesnz
Copy link
Contributor

This appears to be fixed by the work being done to merge the inserter pattern tabs. On #54007 I see the following:
Screenshot 2023-09-07 at 4 06 56 PM

We should retest this once the pattern category PRs are merged.

@glendaviesnz glendaviesnz mentioned this issue Sep 7, 2023
Closed
9 tasks
@bph bph moved this from Triage to In Progress in WordPress 6.4 Editor Tasks Sep 8, 2023
@glendaviesnz
Copy link
Contributor

@jameskoster I have retested on trunk and this issue is now fixed.

@github-project-automation github-project-automation bot moved this from In Progress to Done in WordPress 6.4 Editor Tasks Sep 18, 2023
@github-project-automation github-project-automation bot moved this from In Progress to Done in Patterns Sep 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[Feature] Patterns A collection of blocks that can be synced (previously reusable blocks) or unsynced [Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") [Feature] Synced Patterns Related to synced patterns (formerly reusable blocks) [Type] Bug An existing feature does not function as intended
Projects
No open projects
Patterns
Status: Done
WordPress 6.4 Editor Tasks
Status: Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jameskoster @glendaviesnz