Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Site Editor > Patterns: Empty template parts use the text "Empty pattern" in the placeholder #53821

Closed
carolinan opened this issue Aug 18, 2023 · 2 comments · Fixed by #53842
Closed
Assignees
Labels
[Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended

Comments

@carolinan
Copy link
Contributor

Description

This is a small inconsistency, but if you create a custom template part that is empty, and then go to
Admin > Editor > Patterns > Template parts, then the preview to the right of the menu is empty but has the wrong text. It says pattern instead of template part.

Step-by-step reproduction instructions

Create a custom empty template part through the interface
Go to Admin > Editor > Patterns > Template parts. Select the area used for the part, for example, General.
Confirm that the preview is empty, which is correct, but that the text says "Empty pattern"

Screenshots, screen recording, code snippet

the template part screen in the Site Editor with previews of all available template parts in the general template part area

Environment info

No response

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes

@carolinan carolinan added the [Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") label Aug 18, 2023
@aaronrobertshaw aaronrobertshaw moved this to Todo in Patterns Aug 21, 2023
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Aug 21, 2023
@aaronrobertshaw aaronrobertshaw moved this from Todo to Needs Review in Patterns Aug 21, 2023
@jordesign
Copy link
Contributor

I can confirm this in testing - it also refers to the pattern within the Template Part details screen.

Screenshot 2023-08-30 at 10 24 50 am

@jordesign jordesign added the [Type] Bug An existing feature does not function as intended label Aug 30, 2023
@aaronrobertshaw
Copy link
Contributor

Thanks for the confirmation @jordesign and flagging the additional label.

A fix for both is up in #53842. A quick sanity check and reapproval might be good given I've updated that PR to tweak the extra label since the original green light.

@github-project-automation github-project-automation bot moved this from Needs Review to Done in Patterns Sep 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants