Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Site Editor: Error in browser console when saving entities #53723

Closed
t-hamano opened this issue Aug 16, 2023 · 1 comment
Closed

Site Editor: Error in browser console when saving entities #53723

t-hamano opened this issue Aug 16, 2023 · 1 comment
Labels
[Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") [Type] Bug An existing feature does not function as intended

Comments

@t-hamano
Copy link
Contributor

t-hamano commented Aug 16, 2023

Description

In the Site Editor, if you make changes to a template (perhaps even to a template part, etc.) and press the Save button, an error message will appear in the browser console.

The 'useSelect' hook returns different values when called with the same state and parameters. This can lead to unnecessary rerenders. 
    at EntitiesSavedStates (http://localhost:8888/wp-content/plugins/gutenberg/build/editor/index.min.js?ver=5dc83edfc359b8a42885:3430:3)
    at _EntitiesSavedStates (http://localhost:8888/wp-content/plugins/gutenberg/build/edit-site/index.min.js?ver=41aa4ca25b45c449df04:16046:3)
    at div
    at NavigableRegion (http://localhost:8888/wp-content/plugins/gutenberg/build/edit-site/index.min.js?ver=41aa4ca25b45c449df04:30470:3)
    at SavePanel (http://localhost:8888/wp-content/plugins/gutenberg/build/edit-site/index.min.js?ver=41aa4ca25b45c449df04:16061:65)
    at div
    at div
    at Layout (http://localhost:8888/wp-content/plugins/gutenberg/build/edit-site/index.min.js?ver=41aa4ca25b45c449df04:12142:100)
    at RouterProvider (http://localhost:8888/wp-content/plugins/gutenberg/build/router/index.min.js?ver=4b462bf59ee67d7d784b:178:3)
    at GlobalStylesProvider (http://localhost:8888/wp-content/plugins/gutenberg/build/edit-site/index.min.js?ver=41aa4ca25b45c449df04:6859:3)
    at SlotFillProvider (http://localhost:8888/wp-content/plugins/gutenberg/build/components/index.min.js?ver=9196abfde57f228d14ea:56866:3)
    at SlotFillProvider (http://localhost:8888/wp-content/plugins/gutenberg/build/components/index.min.js?ver=9196abfde57f228d14ea:57283:5)
    at Provider (http://localhost:8888/wp-content/plugins/gutenberg/build/components/index.min.js?ver=9196abfde57f228d14ea:57219:3)
    at div
    at ShortcutProvider (http://localhost:8888/wp-content/plugins/gutenberg/build/keyboard-shortcuts/index.min.js?ver=ece48ff33936234123df:40:87)
    at App (http://localhost:8888/wp-content/plugins/gutenberg/build/edit-site/index.min.js?ver=41aa4ca25b45c449df04:4330:67)

This problem does not occur when the latest Gutenberg plugin is disabled.

Step-by-step reproduction instructions

  • Open the Site Editor.
  • Make changes to the template.
  • Click the "Save" button,

Screenshots, screen recording, code snippet

f863d074af2f6b4d79194a33cffb3c44.mp4

Environment info

No response

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes

@t-hamano t-hamano added [Type] Bug An existing feature does not function as intended [Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") labels Aug 16, 2023
@t-hamano
Copy link
Contributor Author

I am closing this issue as I have found that this log was intentionally added by #53666.

@t-hamano t-hamano closed this as not planned Won't fix, can't repro, duplicate, stale Aug 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

No branches or pull requests

1 participant