Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Link UI "Advanced" button not have "Admin Color" when open #53069

Closed
getdave opened this issue Jul 27, 2023 · 4 comments · Fixed by #54545
Closed

Make Link UI "Advanced" button not have "Admin Color" when open #53069

getdave opened this issue Jul 27, 2023 · 4 comments · Fixed by #54545
Assignees
@getdave
Labels
[Feature] Link Editing Link components (LinkControl, URLInput) and integrations (RichText link formatting) Good First Issue An issue that's suitable for someone looking to contribute for the first time [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended

Comments

@getdave
Copy link
Contributor

getdave commented Jul 27, 2023

Currently when the "Advance" toggle is open on Link Control the color is "Admin Color". Let's change that to be the same as when it's closed (is that right @richtabor?).

I would prefer if the Advanced button wasn't the admin color when opened though.

Originally posted by @richtabor in #52799 (comment)
@getdave getdave added [Type] Bug An existing feature does not function as intended [Feature] Link Editing Link components (LinkControl, URLInput) and integrations (RichText link formatting) labels Jul 27, 2023
@richtabor
Copy link
Member

For reference:

CleanShot 2023-07-28 at 11 12 29

Open state should maintain the $gray-900 color; not have the admin-color applied.

@annezazu annezazu added this to Polish Jul 31, 2023
@annezazu annezazu moved this to Needs development in Polish Jul 31, 2023
@scruffian scruffian mentioned this issue Aug 1, 2023
Merged
@scruffian
Copy link
Contributor

This color is the default color for buttons that are open, so we should make the change to all expanded buttons.

@richtabor
Copy link
Member

Not list view, which this emulates most.

CleanShot 2023-08-09 at 11 22 51

@scruffian scruffian mentioned this issue Aug 11, 2023
Closed
13 tasks
@annezazu annezazu moved this to Needs Review in WordPress 6.4 Editor Tasks Aug 30, 2023
@annezazu annezazu moved this from Needs Review to Needs Dev / Todo in WordPress 6.4 Editor Tasks Aug 30, 2023
@getdave
Copy link
Contributor Author

getdave commented Sep 15, 2023

This seems like a quick win and a "good first PR".

@getdave getdave added the Good First Issue An issue that's suitable for someone looking to contribute for the first time label Sep 15, 2023
@getdave getdave mentioned this issue Sep 18, 2023
Merged
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Sep 18, 2023
@bph bph moved this from Needs Dev / Todo to Needs Review in WordPress 6.4 Editor Tasks Sep 18, 2023
@github-project-automation github-project-automation bot moved this from Needs development to Done in Polish Sep 18, 2023
@github-project-automation github-project-automation bot moved this from Needs Review to Done in WordPress 6.4 Editor Tasks Sep 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@getdave getdave

Labels
[Feature] Link Editing Link components (LinkControl, URLInput) and integrations (RichText link formatting) Good First Issue An issue that's suitable for someone looking to contribute for the first time [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended
Projects
Polish
Status: Done
WordPress 6.4 Editor Tasks
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use gray color on link control advanced toggle WordPress/gutenberg
3 participants
@scruffian @getdave @richtabor