Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pattern inserter: filter by source #53033

Closed
jameskoster opened this issue Jul 27, 2023 · 4 comments
Closed

Pattern inserter: filter by source #53033

jameskoster opened this issue Jul 27, 2023 · 4 comments
Labels
[Feature] Patterns A collection of blocks that can be synced (previously reusable blocks) or unsynced Needs Design Feedback Needs general design feedback. Needs Design Needs design efforts. [Type] Enhancement A suggestion for improvement.

Comments

@jameskoster
Copy link
Contributor

When there are multiple sources (for instance; the active theme and core) it can be desirable to view patterns from one source or the other rather than all of them jumbled together.

In the future it may also be useful to offer users access to patterns bundled with installed-but-inactive themes.

A filtering mechanism in the pattern inserter could enable both of these features. A rough mockup:

Screenshot 2023-07-27 at 14 37 22

Perhaps there alternative solutions? Let's discuss.

@jameskoster jameskoster added [Type] Enhancement A suggestion for improvement. Needs Design Feedback Needs general design feedback. Needs Design Needs design efforts. labels Jul 27, 2023
@hanneslsm
Copy link

hanneslsm commented Jul 27, 2023

In my theme I heavily put focus on intrinsic design. . That would mean that when using a pattern, all corresponding variables must also be loaded - spacing, colors, font-sizes, globally and for specific blocks that are used within. Additionally, fonts? I'm not sure of how much this will affect the performance, but I could imagine that we'd run into situations where people start having 10+ themes installed, only to use some of their patters.

@beafialho
Copy link

Thanks for bringing this up! I think seeing the patterns from a certain theme all together would be really useful. Some users may install themes because they bundle certain patterns they found useful, and from that point of view it seems expectable to see them there clearly and right away.

I find the mockup you shared adds a layer of complexity to the average user. There's no other mention to the active theme's patterns other than when we click that button. Could there be an option where we see the active themes' patterns in the list without these being categories? I think this would make the experience of installing and using a theme clearer.

Captura de ecrã 2023-07-27, às 15 16 09

I'm curious what does "My patterns" contain? Is it a category or a filter?

@jameskoster
Copy link
Contributor Author

@hanneslsm without getting too far into the weeds, I think that speaks to a need for standardised variable naming scheme. #49279 seems relevant in terms of colors.

Could there be an option where we see the active themes' patterns in the list without these being categories?

My concern with this approach is that you lose categorisation which seems like a pretty big trade-off. If a theme bundles hundreds of patterns, it seems likely you'd still want the ability to browse by category? There may also be scalability issues considering that plugins can add patterns too. You risk ending up with a mixture of categories and theme / plugin names which might be detrimental to the browsing experience.

@jameskoster
Copy link
Contributor Author

This is now possible 🎉

@github-project-automation github-project-automation bot moved this from Todo to Done in Patterns Sep 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Patterns A collection of blocks that can be synced (previously reusable blocks) or unsynced Needs Design Feedback Needs general design feedback. Needs Design Needs design efforts. [Type] Enhancement A suggestion for improvement.
Projects
No open projects
Status: Done
Development

No branches or pull requests

4 participants