Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copying a theme/plugin pattern should open up the patten in its detail view #52649

Closed
richtabor opened this issue Jul 14, 2023 · 2 comments · Fixed by #53214
Closed

Copying a theme/plugin pattern should open up the patten in its detail view #52649

richtabor opened this issue Jul 14, 2023 · 2 comments · Fixed by #53214
Assignees
Labels
[Feature] Patterns A collection of blocks that can be synced (previously reusable blocks) or unsynced [Status] In Progress Tracking issues with work in progress [Type] Enhancement A suggestion for improvement.

Comments

@richtabor
Copy link
Member

When copying a pattern bundled with a theme or plugin into "My Patterns", the pattern should be opened up in its detail view. Currently you copy, read the snackbar notification, click the action, then click on the pattern.

Copying a pattern to "My Patterns" assumes you want to likely edit that pattern.

CleanShot.2023-07-14.at.15.39.53.mp4
@richtabor richtabor added [Type] Enhancement A suggestion for improvement. [Feature] Patterns A collection of blocks that can be synced (previously reusable blocks) or unsynced labels Jul 14, 2023
@aaronrobertshaw
Copy link
Contributor

For some added background here, when the pattern duplication was added it initially when to the pattern edit view. That was a little jarring so as a result the user was left on the Patterns page.

Being sent immediately to edit the duplicated pattern was a bit unexpected for me. Could we try remaining in the management view?

I'll spin up a PR tomorrow that takes the user to the new pattern's detail view so it can be played with.

@aaronrobertshaw aaronrobertshaw self-assigned this Aug 1, 2023
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Aug 1, 2023
@aaronrobertshaw
Copy link
Contributor

There wasn't a lot involved in rolling it back to go to the pattern details view. A PR is up in #53214.

@aaronrobertshaw aaronrobertshaw moved this to Todo in Patterns Aug 3, 2023
@aaronrobertshaw aaronrobertshaw moved this from Todo to Needs Review in Patterns Aug 3, 2023
@github-project-automation github-project-automation bot moved this from Needs Review to Done in Patterns Aug 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Patterns A collection of blocks that can be synced (previously reusable blocks) or unsynced [Status] In Progress Tracking issues with work in progress [Type] Enhancement A suggestion for improvement.
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants