Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Instagram block should be accepted Instagram URL only #5241

Closed
usmaniqbalse opened this issue Feb 25, 2018 · 5 comments
Closed

Instagram block should be accepted Instagram URL only #5241

usmaniqbalse opened this issue Feb 25, 2018 · 5 comments
Labels
[Block] Embed Affects the Embed Block [Feature] Blocks Overall functionality of blocks [Type] Enhancement A suggestion for improvement.

Comments

@usmaniqbalse
Copy link

Issue Overview

Instagram block should be accepted Instagram profile URLs only.

Steps to Reproduce (for bugs)

  1. Just drop the Instagram block
  2. Add any other URL except the Instagram profile URL
  3. For more details, please see attached video

Gutenberg 2.2
WordPress 4.9.4
Chorome 64.0.3282.167

Expected Behavior

Block should accept Instagram URL only

Current Behavior

Block accepts every site URL containing media content

Screenshots / Video

instagram - blcok input validation
@karmatosed
Copy link
Member

I think that's a reasonable check. If it is any specific service we should do a check.

@karmatosed karmatosed added the [Type] Enhancement A suggestion for improvement. label Mar 6, 2018
@karmatosed karmatosed added this to the Merge Proposal milestone Mar 6, 2018
@Kluny
Copy link
Contributor

Kluny commented Mar 12, 2018

I'd like to work on this if no one else is.

@danielbachhuber
Copy link
Member

Related #6824

@danielbachhuber danielbachhuber mentioned this issue May 18, 2018
Closed
@Dec0y-jb
Copy link

It looks like this actually affects all of the embed blocks, not just Instagram; I was able to replicate this with several others as well.

@mtias mtias removed this from the Merge: Editor milestone Oct 3, 2018
@mtias mtias added [Feature] Blocks Overall functionality of blocks [Block] Embed Affects the Embed Block labels Oct 3, 2018
@notnownikki
Copy link
Member

The current behaviour is that if you put, for example, a twitter URL into a YouTube block, the block will switch to a Twitter block.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[Block] Embed Affects the Embed Block [Feature] Blocks Overall functionality of blocks [Type] Enhancement A suggestion for improvement.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
7 participants
@danielbachhuber @karmatosed @Kluny @mtias @notnownikki @usmaniqbalse @Dec0y-jb