Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: Improve language and options for when blocks are modified externally #5233

Closed
mathetos opened this issue Feb 24, 2018 · 3 comments
Closed
Assignees
Labels
[Feature] Blocks Overall functionality of blocks [Type] Copy Issues or PRs that need copy editing assistance [Type] Enhancement A suggestion for improvement.

Comments

@mathetos
Copy link

Issue Overview

The current text that explains what options are available when a block is found to have been modified externally is very confusing. This is the text currently:

image

This block appears to have been modified externally. Overwrite the changes or Convert to Classic or Custom HTML to keep your changes.

This explanation does not make it obvious what will happen if you click on the "Overwrite" button. For example, clicking "Overwrite" suggests that the external modifications will be overwritten -- but that's not the case. Instead, the block markup itself is overwritten. The Gutenberg demo itself has done this with the cover image, the markup is changed so that the image can be loaded offsite.

Additionally, it is not necessary to convert to Classic or HTML blocks in order to keep your changes, the existing block can be updated by clicking "Overwrite".

Lastly, in the case of the cover image specifically, if you convert to Classic or HTML, you lose the ability to have the full-bleed effect that the cover image supports. So that should also be highlighted somehow.

Possible Solution

I suggest this as an alternative. This change includes the following:

  1. Adds the dynamic name of the block type that is in question.
  2. Clarifies the actions that happen with each button.
  3. Changes "Edit as HTML" to "Convert to HTML Block" for consistency

This [BLOCK NAME] block appears to have been modified externally. To update this block with these modifications, click "Update." Alternatively, you can convert this block to either the Classic or HTML blocks. Converting to another block type might result in different block options.

Buttons: [[ Update ]] [[ Convert to Classic Block ]] [[ Convert to HTML Block ]]

@Soean Soean added [Type] Enhancement A suggestion for improvement. [Feature] Blocks Overall functionality of blocks [Type] Copy Issues or PRs that need copy editing assistance labels Feb 24, 2018
@karmatosed karmatosed self-assigned this Apr 25, 2018
@jasmussen
Copy link
Contributor

Is this issue subsumed by #7604?

@mathetos
Copy link
Author

mathetos commented Jul 2, 2018

@jasmussen Probably better to close this in favor of #7604 since this is so old at this point.

@mathetos mathetos closed this as completed Jul 2, 2018
@jasmussen
Copy link
Contributor

Thanks so much for your work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Blocks Overall functionality of blocks [Type] Copy Issues or PRs that need copy editing assistance [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

No branches or pull requests

4 participants