Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renaming Reusable Blocks Should Still Be Discoverable #52194

Closed
courtneyr-dev opened this issue Jun 30, 2023 · 14 comments · Fixed by #52543
Closed

Renaming Reusable Blocks Should Still Be Discoverable #52194

courtneyr-dev opened this issue Jun 30, 2023 · 14 comments · Fixed by #52543
Assignees
Labels
[Feature] Patterns A collection of blocks that can be synced (previously reusable blocks) or unsynced [Type] Bug An existing feature does not function as intended

Comments

@courtneyr-dev
Copy link
Contributor

Description

As a user familiar with Reusable Blocks, I expect to find them as a search result when inserting a block even if that feature has moved. Assume I do not know that the feature as moved.

How do I navigate to see all reuseable blocks I previously created? How do I get to the manage reusable blocks counterpart?

Step-by-step reproduction instructions

In 6.2.2:

  • Create a Reusable Block
  • Insert it from the Block Inserter searching for "reusable" and/or the reusable block tab
  • Insert it using the / command in a paragraph block searching for "reusable"

In 6.3b2
Attempt the same

Screenshots, screen recording, code snippet

reusable63b2.mp4
ScreenFlow.mp4

Environment info

No response

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes

@Mamaduka Mamaduka added the [Feature] Patterns A collection of blocks that can be synced (previously reusable blocks) or unsynced label Jul 1, 2023
@Mamaduka
Copy link
Member

Mamaduka commented Jul 1, 2023

Probably related issues: #51944, #52150.

cc @aaronrobertshaw

@ndiego ndiego added the [Type] Bug An existing feature does not function as intended label Jul 3, 2023
@ndiego ndiego moved this to 📥 Todo in WordPress 6.3.x Editor Tasks Jul 3, 2023
@ndiego
Copy link
Member

ndiego commented Jul 3, 2023

I just added this to the 6.3 project board as a Todo.

@courtneyr-dev
Copy link
Contributor Author

courtneyr-dev commented Jul 3, 2023

This is partially resolved in beta 3. Let's continue to check on the / command insertion method.

image

image

image

@ndiego
Copy link
Member

ndiego commented Jul 3, 2023

Let's continue to check on the / command insertion method.

It would be good to keep the 6.2 functionality until perhaps 6.4. This will let folks migrate to the new "patterns" paradigm more gracefully.

@courtneyr-dev
Copy link
Contributor Author

courtneyr-dev commented Jul 11, 2023

Beta 4: I am so happy with the prompts for users to know it has been renamed. I still wonder if /reusable should work, as /pattern does.
image
image
image
image
image

@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Jul 12, 2023
@noisysocks noisysocks moved this from 📥 Todo to 🏗️ In Progress in WordPress 6.3.x Editor Tasks Jul 12, 2023
@github-project-automation github-project-automation bot moved this from 🏗️ In Progress to ✅ Done in WordPress 6.3.x Editor Tasks Jul 13, 2023
@courtneyr-dev
Copy link
Contributor Author

Thanks @noisysocks!

@annezazu
Copy link
Contributor

After seeing this change in beta 4 for create pattern/reusable block, I wanted to chime in as, while I understand this helps in the creation flow, it isn't going to help reduce confusion when thinking about the entire experience. I worry it might add to it. For example, here's a screenshot of what I see on a current reusable block after switching from 6.2.2 to 6.3 beta 4:

Screen Shot 2023-07-12 at 2 15 04 PM

I think consistency across the different flows, along with the built in nudges, will help immensely. Are there other options to consider here that might work? For example, I can see we have concerns about the accessibility of the menu as is but @alexstine shares the following:

Another option might be to go with @talldan's suggestion above. Using aria-describedby or aria-description might work fine. Although I think aria-description still lacks browser support in some cases.

@richtabor @karmatosed for 6.3 in case you all have any thoughts here.

@annezazu annezazu reopened this Jul 13, 2023
@richtabor
Copy link
Member

Create pattern/reusable block isn't ideal.

I wonder if it will help if the control renders "Create synced pattern" and the sync control is enabled by default.

This is an existing reusable blocks control that folks who use reusable blocks will be looking for — and we're calling reusable blocks "synced patterns" now.

@glendaviesnz
Copy link
Contributor

@richtabor, @annezazu, @courtneyr-dev what do you think of the idea of only showing Create pattern/reusable block until the user has seen and dismissed one of the rename prompts, once they have dismissed the prompt we assume "discovery phase over" and revert to Create pattern for the menu? That way they aren't stuck with that less than optimal menu for the whole of the 6.3 release.

@glendaviesnz
Copy link
Contributor

"Create synced pattern" and the sync control is enabled by default.

I think this would help as the default action is then the previous behaviour. @SaxonF what do you think about this?

@ndiego
Copy link
Member

ndiego commented Jul 14, 2023

"Create synced pattern" and the sync control is enabled by default.

Making the toggle enabled by default would make the experience more consistent for current reusable block users.

@glendaviesnz
Copy link
Contributor

glendaviesnz commented Jul 16, 2023

There is a PR here that renames the menu when the prompt is dismissed and also makes synced the default - probably good to get ✅ and into RC1 if possible.

@courtneyr-dev
Copy link
Contributor Author

RC1 tested and I can find using /reusable 💯
image

@glendaviesnz
Copy link
Contributor

Closing this as I think the discoverability is covered off for reusable blocks. We still need to look at the discrepancy of unsynced patterns not displaying in the quick inserter, but this is covered on this issue.

@priethor priethor removed the [Status] In Progress Tracking issues with work in progress label Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Patterns A collection of blocks that can be synced (previously reusable blocks) or unsynced [Type] Bug An existing feature does not function as intended
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

8 participants