Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

My Patterns vs. Custom Patterns #51939

Closed
richtabor opened this issue Jun 26, 2023 · 4 comments · Fixed by #51949
Closed

My Patterns vs. Custom Patterns #51939

richtabor opened this issue Jun 26, 2023 · 4 comments · Fixed by #51949
Assignees
Labels
[Feature] Patterns A collection of blocks that can be synced (previously reusable blocks) or unsynced Needs Design Feedback Needs general design feedback.

Comments

@richtabor
Copy link
Member

I'm a bit concerned that "custom" does not imply enough ownership/origin. I question if using something like "My Patterns" would convey better?

"Custom" is used during initial create of "custom" templates, But those are also much less visible as "custom" entities.

Custom patterns:

CleanShot 2023-06-26 at 16 14 38 CleanShot 2023-06-26 at 16 14 10

As seen in templates:

CleanShot 2023-06-26 at 16 16 10 CleanShot 2023-06-26 at 16 20 47 CleanShot 2023-06-26 at 16 18 35
@richtabor richtabor added Needs Design Feedback Needs general design feedback. [Feature] Patterns A collection of blocks that can be synced (previously reusable blocks) or unsynced labels Jun 26, 2023
@richtabor
Copy link
Member Author

There is no mention of "custom" when creating patterns as well.

CleanShot 2023-06-26 at 16 30 10

@talldan
Copy link
Contributor

talldan commented Jun 27, 2023

I'm a bit concerned that "custom" does not imply enough ownership/origin. I question if using something like "My Patterns" would convey better?

@richtabor The patterns that appear here could be created by multiple users. Happy to go with the renaming if you think it's better, but just wanted to make sure you're aware of that caveat.

@jasmussen
Copy link
Contributor

jasmussen commented Jun 27, 2023

I quite like your concept in #51943, both the spacing and the star. "My patterns" also reads well, though Dan makes a good point. Also worth thinking about is the future where you can save patterns from a theme, then delete that theme. Or even the fact that you could save your own custom patterns to any of the existing categories (Featured, Posts, Footers, etc).

So essentially "Custom patterns" today are essentially "Uncategorized patterns that users saved", but in the future they will just be patterns on par with all other patterns, regardless of their origin. In that light I wonder if, for now, we call them "Saved patterns", group them at the top with a star like in 51943. But then in the future, they can become "My patterns" and be more of a tag behavior than a category, simply showing the patterns you created, even if they are also filed in the various categories as well.

@richtabor
Copy link
Member Author

simply showing the patterns you created, even if they are also filed in the various categories as well.

Exactly my thinking. 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Patterns A collection of blocks that can be synced (previously reusable blocks) or unsynced Needs Design Feedback Needs general design feedback.
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

4 participants