Site Editor: Navigator's goTo function called twice when navigating screens in the sidebar

[ciampo]

When interacting with the sidebar in the site editor, clicking buttons to navigate to a new screen seems to call the underlying goTo function twice:

• one call is triggered (correctly) by NavigatorButton, used to render those buttons
• one extra call seems to be triggered by the useSyncPathWithURL hook, in particular by this line of code

Calling goTo twice can prevent Navigator from working as expected — for example, when navigating to the previous/parent screen, the focus is currently not being restored correctly on the button that triggered the previous navigation

cc @youknowriad

[youknowriad]

one extra call seems to be triggered by the useSyncPathWithURL hook, in particular by this line of code

This is something I'd like to remove by making the Navigator component controlled. Otherwise, it's very hard to address all the edge cases in these two-way synchronization and React effects.

[youknowriad]

We removed the component and removed a lot of the syncing, so this is issue is not relevant anymore