Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Track Navigation related code duplication in codebase #51455

Closed
getdave opened this issue Jun 13, 2023 · 2 comments
Closed

Track Navigation related code duplication in codebase #51455

getdave opened this issue Jun 13, 2023 · 2 comments
Assignees
@draganescu @scruffian @getdave @MaggieCabrera
Labels
[Block] Navigation Affects the Navigation Block

Comments

@getdave
Copy link
Contributor

getdave commented Jun 13, 2023 •
edited
Loading

Please see #51446

As the scope of "Navigation" extends outside of the core/navigation block we are observing a proliferation of Navigation related code.

Whilst this is currently (relatively) manageable - and we should be mindful of the need not to pre-optimise - it's important we keep track of this for reference and potential future refactorings.

As and when instances of duplication of variance are discovered we should note them here:

  • X
  • Y
  • Z
@getdave getdave added the [Block] Navigation Affects the Navigation Block label Jun 13, 2023
@getdave getdave mentioned this issue Jun 13, 2023
Merged
@MaggieCabrera
Copy link
Contributor

#51446 @scruffian opened an issue already :D

@getdave
Copy link
Contributor Author

getdave commented Jun 13, 2023

Haha! We discussed it but I thought I'd help him out. I"ll close this one out.

@getdave getdave closed this as completed Jun 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@draganescu draganescu

@scruffian scruffian

@getdave getdave

@MaggieCabrera MaggieCabrera

Labels
[Block] Navigation Affects the Navigation Block
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@draganescu @scruffian @getdave @MaggieCabrera