Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When editing a page in the site editor, blocks inside Post Content should be directly selectable #51259

Closed
jameskoster opened this issue Jun 6, 2023 · 10 comments · Fixed by #51780
Assignees
Labels
[Feature] Page Content Focus Ability to toggle between focusing on editing the page and editing the template in the site editor. [Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") Needs Design Feedback Needs general design feedback.

Comments

@jameskoster
Copy link
Contributor

If you open a Page in the Site Editor (Pages > Page > Edit), you cannot directly select blocks inside Post Content – The Post Content block itself is selected first. Since you cannot do anything with the Post Content block in this context, this adds some friction to the experience.

Notice in the video below that I have to click twice to select the Image block:

pc.mp4

Would making child blocks of Post Content directly selectable be worth a try?

cc @WordPress/gutenberg-design

@jameskoster jameskoster added Needs Design Feedback Needs general design feedback. [Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") labels Jun 6, 2023
@jasmussen
Copy link
Contributor

Consistency seems to be the most important thing to find here. What is the intended behavior for selecting blocks in this context? Is it the clickthrough as applied here? How, generally, are we applying clickthrough these days? Is it a part of the new content/template editing split?

@jameskoster
Copy link
Contributor Author

Yes it would be good to define that more clearly.

The original intent for the click-through pattern was to help indicate when you're working with something beyond the scope of the original edit focus. For example: Selecting a header while editing a template, or; selecting a Reusable block while editing a page.

But now that we have purple colorisation of synced blocks, it may no longer be necessary. Especially if #50796 is implemented.

In any case, since the 'edit focus' in this flow is the page, having to click through the Post Content block feels a bit unnecessary.

@paaljoachim
Copy link
Contributor

First off all it is important for a user to really understand when a template is being edited compared to post/page content.
That means making a clear differentiation between template vs post content. If these slide too much into each other it can become very confusing.

Brain storming.

1- Let's say that clicking the Post Content block brings up a kind of message overlay of the block asking the user if they want to edit the post/page content.

2- Let's say that clicking the Post Content block shows something similar to a Reusable block.
Screenshot 2023-06-06 at 13 04 39

2- Or something like a template part.
Screenshot 2023-06-06 at 13 07 03

The main point is that we are now seeing the edit of a post gradually merge with editing a template. For the Front Page and Home templates that can work nicely. As they each only affect the front page and the blog page. The more difficult part is when the same gradual merge applies to a page template or post template. What does the Post Content block look like in a Page or Post Template? Should it look different compared to where the template only affects one page?

Example. Post Content for the Front page and Blog can be seen in the templates.
Post Content for multiple pages should be different as it can not show content as this varies from page to page.

@jameskoster
Copy link
Contributor Author

Let's say that clicking the Post Content block brings up a kind of message overlay of the block asking the user if they want to edit the post/page content.

This feels unnecessary to me. If a user has navigated through the Pages panel, selected a page, and clicked edit... isn't it implied that they want to edit the page content?

@paaljoachim
Copy link
Contributor

Hey James.
Will one see Post Content when editing a page in the Pages panel? Ok it sounds like it. I believe a few different PR's need to land before I get a better perspective on what this will look like.

So I got to say yes to your question there. As one is editing a page it is implied that they want to edit the page content.

@aurooba
Copy link
Member

aurooba commented Jun 8, 2023

But you would select the Post Content block if you wanted to move it around using the arrows in its toolbar. I can see an argument for that being a secondary action for which a person could go and purposefully select the Post Content block from the breadcrumbs or list view if needed, but I agree with @jasmussen that consistency is more important here.

@jameskoster
Copy link
Contributor Author

But you would select the Post Content block if you wanted to move it around using the arrows in its toolbar

The Post Content block cannot be moved when you're editing the page because it's part of the template. The toolbar doesn't even appear. Those kind of actions can only be performed when editing the template. That's another reason why it feels particularly strange for Post Content to be selected before you can work with any child blocks.

@aurooba
Copy link
Member

aurooba commented Jun 8, 2023

The Post Content block cannot be moved when you're editing the page because it's part of the template.

Oooh, this must be a feature that hasn't landed in a stable release of Gutenberg yet (I haven't updated to 16 RC yet), because I am able to move the post content block when I'm in the page editor within the site editor (in Twenty Twenty Three). And it definitely looks different from your video recording. Is this part of the upcoming release?

Screen.Recording.2023-06-08.at.10.14.45.AM.mov

@SaxonF
Copy link
Contributor

SaxonF commented Jun 9, 2023

+1 . Added to the follow up list

@jameskoster
Copy link
Contributor Author

Is this part of the upcoming release?

That's correct, apologies I should have made that clearer!

@jameskoster jameskoster moved this to Needs dev in 6.3 Design Jun 15, 2023
@ndiego ndiego moved this to ❓ Triage in WordPress 6.3.x Editor Tasks Jun 15, 2023
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Jun 22, 2023
@github-project-automation github-project-automation bot moved this from ❓ Triage to ✅ Done in WordPress 6.3.x Editor Tasks Jun 23, 2023
@noisysocks noisysocks added the [Feature] Page Content Focus Ability to toggle between focusing on editing the page and editing the template in the site editor. label Jun 26, 2023
@apeatling apeatling moved this from Needs dev to Done in 6.3 Design Jun 27, 2023
@priethor priethor removed the [Status] In Progress Tracking issues with work in progress label Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Page Content Focus Ability to toggle between focusing on editing the page and editing the template in the site editor. [Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") Needs Design Feedback Needs general design feedback.
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

7 participants