-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
When editing a page in the site editor, blocks inside Post Content should be directly selectable #51259
Comments
Consistency seems to be the most important thing to find here. What is the intended behavior for selecting blocks in this context? Is it the clickthrough as applied here? How, generally, are we applying clickthrough these days? Is it a part of the new content/template editing split? |
Yes it would be good to define that more clearly. The original intent for the click-through pattern was to help indicate when you're working with something beyond the scope of the original edit focus. For example: Selecting a header while editing a template, or; selecting a Reusable block while editing a page. But now that we have purple colorisation of synced blocks, it may no longer be necessary. Especially if #50796 is implemented. In any case, since the 'edit focus' in this flow is the page, having to click through the Post Content block feels a bit unnecessary. |
This feels unnecessary to me. If a user has navigated through the Pages panel, selected a page, and clicked edit... isn't it implied that they want to edit the page content? |
Hey James. So I got to say yes to your question there. As one is editing a page it is implied that they want to edit the page content. |
But you would select the Post Content block if you wanted to move it around using the arrows in its toolbar. I can see an argument for that being a secondary action for which a person could go and purposefully select the Post Content block from the breadcrumbs or list view if needed, but I agree with @jasmussen that consistency is more important here. |
The Post Content block cannot be moved when you're editing the page because it's part of the template. The toolbar doesn't even appear. Those kind of actions can only be performed when editing the template. That's another reason why it feels particularly strange for Post Content to be selected before you can work with any child blocks. |
Oooh, this must be a feature that hasn't landed in a stable release of Gutenberg yet (I haven't updated to 16 RC yet), because I am able to move the post content block when I'm in the page editor within the site editor (in Twenty Twenty Three). And it definitely looks different from your video recording. Is this part of the upcoming release? Screen.Recording.2023-06-08.at.10.14.45.AM.mov |
+1 . Added to the follow up list |
That's correct, apologies I should have made that clearer! |
If you open a Page in the Site Editor (Pages > Page > Edit), you cannot directly select blocks inside Post Content – The Post Content block itself is selected first. Since you cannot do anything with the Post Content block in this context, this adds some friction to the experience.
Notice in the video below that I have to click twice to select the Image block:
pc.mp4
Would making child blocks of Post Content directly selectable be worth a try?
cc @WordPress/gutenberg-design
The text was updated successfully, but these errors were encountered: