-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
List View: Reduce visual weight of locked nested blocks #50748
Comments
Ah of course, went a bit fast there. Thanks. And yes, I agree, lots of opportunities here to improve the list view and its features in general..
I think I agree simply on the fact that I stumbled on this just now, that even though an ancestor can be locked, children inside are not. To reference Figma yet again, this is also the case here. The children can be locked, but they are also de-facto locked when an ancestor is locked. So it's probably more than a visual tweak if we wanted to apply this here. But it does also seem valuable the block editor use case to allow the other, locking just the ancestor while keeping children unlocked, for example to make a particular edit operation safer. So it's not a direct comparison, and probably not that useful to compare too much. But that said, the default behavior could still be to apply to children. No strong opinion there. I also feel like contentOnly locking is sorely underused for pattern building. As far as I know, that still requires code editing. It'd be nice to consider a locking modal + list view + contentOnly triad for a design sprint. What do you think? |
100%. There may be a way to leverage a popover instead of modal even. Perhaps a flyover/nested dropdown whenever toggled from the Block Options menu. Or if you could click on lock icons (revealed similar to what's proposed for showing/hiding here) then that could work as well. Not sure we need locking so front-and-center though. |
I'm curious if a parent is locked whether we may not want to expand it and keep the whole thing collapsed? |
We do allow for unlocking of nested blocks within a locked block, which makes me lean towards keeping them expandable. |
Right, I was thinking more about cases where we might lock the whole block down (#51968) — it seems in those you shouldn't be able to expand. |
Noticed this in Fimga recently, where contents within a locked group would show a small circle, instead of another lock icon. It reduces visual weight of locked blocks within List View, making locked block contents less bulky and more scannable.
Perhaps worth exploring a bit.
Current
Proposed
The text was updated successfully, but these errors were encountered: