Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Heading level tooltip covers subsequent level #50402

Closed
mrwweb opened this issue May 5, 2023 · 12 comments · Fixed by #56035
Closed

Heading level tooltip covers subsequent level #50402

mrwweb opened this issue May 5, 2023 · 12 comments · Fixed by #56035
Assignees
Labels
[Block] Heading Affects the Headings Block [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). Needs Design Feedback Needs general design feedback. [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended

Comments

@mrwweb
Copy link

mrwweb commented May 5, 2023

Description

When hovering over a heading level, the next heading level is covered. This is extremely inconvenient, because in practice this means that Heading 3—the most likely heading a user would want to select since Heading 2 is default and followed by 3—is covered by the Heading 2 tooltip as the cursor passes over Heading Level 2 on the way to Level 3.

Step-by-step reproduction instructions

  1. Insert heading block.
  2. Select heading level setting in block toolbar
  3. Move cursor directly down toward Heading 3
  4. Tooltip from hovering over Heading 2 obscures majority of Heading 3 button

Screenshots, screen recording, code snippet

The heading bock toolbar with the heading level setting expanded. The "Heading 2" tooltip is obscuring the Heading 3 button.

Environment info

  • WordPress 6.2
  • Firefox
  • Windows
  • Any theme / plugins

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

No

@ramonjd
Copy link
Member

ramonjd commented May 8, 2023

Just checking, do you mean the black-background tooltip? I couldn't grok it from the screenshot in the description. E.g.,

Screenshot 2023-05-08 at 11 07 20 am

I wonder if making the list horizontal might be acceptable 🤔

Screenshot 2023-05-08 at 11 07 49 am

@ramonjd ramonjd added Needs Design Feedback Needs general design feedback. [Type] Feedback Issues that relate purely to feedback on a feature that isn't necessarily actionable [Block] Heading Affects the Headings Block labels May 8, 2023
@jasmussen
Copy link
Contributor

It looks like the component only supports positions above and below, but my first instinct would've been to show the tooltip to the right of the heading level. Showing horizontally is also an option. I think I actually saw some designs for this a while back.

@mrwweb
Copy link
Author

mrwweb commented May 8, 2023

@ramonjd I believe that in earlier versions of WP the heading menu was horizontal as you show, so I wonder about why it was changed. (My guess would that be that straight down motion is easier for users thanks to Fitt's Law: Straight down for a variable distance is easier than across at a variable angle.)

Other options:

  1. Don't use a tooltip
  2. Spell out "Heading" (so also no tooltip)

I think I might really like option 2?

@ramonjd
Copy link
Member

ramonjd commented May 9, 2023

Spell out "Heading" (so also no tooltip)

Do mean remove the icons like this (but better looking) 😄 ?

Screenshot 2023-05-09 at 11 07 05 am

@mrwweb
Copy link
Author

mrwweb commented May 9, 2023

@ramonjd You got it! It seems that space wouldn't be a concern there, and I could imagine it might even be slightly clearer to folks.

@t-hamano
Copy link
Contributor

I would like to suggest that this issue be considered at the same time as the site title block. The Site Title block has both an icon and a title.

site-title

@t-hamano
Copy link
Contributor

I also discovered that the heading icons used in the site title block and heading block are made in size 20 instead of the basic size 24 of the other icons.

I reported this in #50520.

@carolinan
Copy link
Contributor

In #46003, I proposed using the design from the site title block, where the name of the tag is always visible, but based on feedback I changed it back to the design that only uses the icon. Happy to change it again.

@t-hamano
Copy link
Contributor

Update: In #50856, all heading-level icons have been added to the icons package. These icons may also be available for this issue.

@mrwweb
Copy link
Author

mrwweb commented May 24, 2023

@carolinan I really love that PR you made! Changing the heading level selector to show the icons + text label seems like an especially good idea given that the list includes "Paragraph" for the Site Title.

So it feels like #46003 would resolve this issue and have a ton of other benefits (clarity, no tooltip, shared compontents, filtering heading levels).

@afercia
Copy link
Contributor

afercia commented Nov 8, 2023

This problem was recently reported also on #55927 and it is still a clear issue for a good user experience. I kindly disagree with the design feedback provided on #46003

Having both the icon and visible text seems to be the most appropriate solution here. The icon represents a visual hint that may help some users, while the visible text is universally accessible to everyone.
I'd also like to remind that icon-only buttons have inherent usability and accessibility problems. Their usage should be limited to only the cases where there isn't enough space to use visible text. This is not the case, as there's a lot of space to show visible text.

@afercia
Copy link
Contributor

afercia commented Nov 10, 2023

Aside: For the site title this dropdown options also include a button for a paragraph. In this case, I'd argue the dropdown menu name 'Change level' isn't ideal:

Screenshot 2023-11-10 at 08 50 54

@afercia afercia self-assigned this Nov 10, 2023
@afercia afercia added [Type] Bug An existing feature does not function as intended [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). and removed [Type] Feedback Issues that relate purely to feedback on a feature that isn't necessarily actionable labels Nov 10, 2023
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Nov 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Heading Affects the Headings Block [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). Needs Design Feedback Needs general design feedback. [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants