Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Post Editor: List View has no close button on mobile viewports #48982

Closed
talldan opened this issue Mar 10, 2023 · 4 comments · Fixed by #49200
Closed

Post Editor: List View has no close button on mobile viewports #48982

talldan opened this issue Mar 10, 2023 · 4 comments · Fixed by #49200
Assignees
@jorgefilipecosta @ntsekouras
Labels
[Feature] List View Menu item in the top toolbar to select blocks from a list of links. Mobile Web Viewport sizes for mobile and tablet devices [Package] Edit Post /packages/edit-post [Priority] High Used to indicate top priority items that need quick attention [Type] Regression Related to a regression in the latest release

Comments

@talldan
Copy link
Contributor

talldan commented Mar 10, 2023 •
edited
Loading

Description

On mobile viewports List View doesn't have a close button, so there's probably no way of closing it.

Usually this wouldn't be too much of an issue, as there's no way to open List View on mobile viewports. But if a user has the 'Always open List View' preference enabled, List View fills the whole screen when entering the editor and there's no way to get rid of it, essentially making the editor unusuable

The tabs also look a little buggy visually.

Step-by-step reproduction instructions

  1. Open the post editor
  2. Enable the 'Always open List View' preference.
  3. Resize your browser to mobile size
  4. Refresh

Expected: There's a way to close List View AND/OR List View doesn't show on mobile viewports
Actual: There's no close button and List View fills the whole screen 😱

Screenshots, screen recording, code snippet

Screen Shot 2023-03-10 at 11 55 11 am

Environment info

Latest WordPress trunk (with or without the Gutenberg plugin active at latest trunk)
Discovered using Brave / Mac OS

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes
@talldan talldan added [Priority] High Used to indicate top priority items that need quick attention Mobile Web Viewport sizes for mobile and tablet devices [Type] Regression Related to a regression in the latest release [Feature] List View Menu item in the top toolbar to select blocks from a list of links. [Package] Edit Post /packages/edit-post labels Mar 10, 2023
@talldan talldan moved this to ❓ Triage in WordPress 6.2 Editor Tasks Mar 10, 2023
@talldan
Copy link
Contributor Author

talldan commented Mar 10, 2023

I think this is a result of #44788, where a bunch of issues with the implementation were pointed out, but never addressed. Hopefully @jorgefilipecosta can take a look.

@annezazu annezazu moved this from ❓ Triage to 📥 Todo in WordPress 6.2 Editor Tasks Mar 14, 2023
@ntsekouras ntsekouras mentioned this issue Mar 20, 2023
Merged
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Mar 20, 2023
@github-project-automation github-project-automation bot moved this from 📥 Todo to ✅ Done in WordPress 6.2 Editor Tasks Mar 20, 2023
@nomad-skateboarding-dev
Copy link

Hi @talldan !

Question as a mobile only user, please and thank you. 🙂

I've never seen the List View option at all. How does one get it to show?

@talldan
Copy link
Contributor Author

talldan commented Mar 22, 2023

@nomad-skateboarding-dev I think you can only see the List View toggle icon when your phone is in landscape on mobile web. It seems like you can switch to Landscape, toggle list view on, and then go back to portrait and it'll be active in a more usable. At least there is a way to close it now that this issue has been fixed.

@nomad-skateboarding-dev
Copy link

Thank you kindly! I was aware of landscape view option, so that's good to know I wasn't completely missing something over the past 2 years. 🙂🙌

@annezazu annezazu mentioned this issue May 4, 2023
Open
@priethor priethor removed the [Status] In Progress Tracking issues with work in progress label May 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jorgefilipecosta jorgefilipecosta

@ntsekouras ntsekouras

Labels
[Feature] List View Menu item in the top toolbar to select blocks from a list of links. Mobile Web Viewport sizes for mobile and tablet devices [Package] Edit Post /packages/edit-post [Priority] High Used to indicate top priority items that need quick attention [Type] Regression Related to a regression in the latest release
Projects
No open projects
WordPress 6.2 Editor Tasks
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Show close button in List View on mobile WordPress/gutenberg
5 participants
@talldan @jorgefilipecosta @ntsekouras @priethor @nomad-skateboarding-dev