Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Site Editor Navigation Panel: Loading state feels a bit fragile #48682

Closed
jameskoster opened this issue Mar 2, 2023 · 2 comments
Closed

Site Editor Navigation Panel: Loading state feels a bit fragile #48682

jameskoster opened this issue Mar 2, 2023 · 2 comments
Labels
[Block] Navigation Affects the Navigation Block [Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing")

Comments

@jameskoster
Copy link
Contributor

jameskoster commented Mar 2, 2023

loading.mp4

There are two issues to fix:

  1. The loading indicator is visually very bright, could we tone this down a bit so it sits nicer against the dark material?
  2. Some menu items appear before others resulting in a staggered load. It's not so bad with small menus but with larger ones it feels quite clunky.
@jameskoster jameskoster added [Block] Navigation Affects the Navigation Block [Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") labels Mar 2, 2023
@jameskoster jameskoster changed the title Site Editor Navigation Panel: Loading state can feels a bit fragile Site Editor Navigation Panel: Loading state feels a bit fragile Mar 2, 2023
@jasmussen
Copy link
Contributor

Good issue. Yes, we need to consolidate on using spinners for loading states. Skeleton indicators can be separately explored for placeholders, but we've tried them for both social links and navigaiton in the past, and it hasn't worked out, so let's avoid those for loading states.

@scruffian
Copy link
Contributor

The loading states have changed, I think we can close this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Navigation Affects the Navigation Block [Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing")
Projects
None yet
Development

No branches or pull requests

3 participants