Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Isolated Template Part Mode is empty when editing #48114

Closed
annezazu opened this issue Feb 16, 2023 · 5 comments
Closed

Isolated Template Part Mode is empty when editing #48114

annezazu opened this issue Feb 16, 2023 · 5 comments
Labels
[Block] Template Part Affects the Template Parts Block [Feature] Focus Mode Zoomed in focus mode for editing things like template parts [Type] Bug An existing feature does not function as intended

Comments

@annezazu
Copy link
Contributor

Description

Using 6.2-beta2-55349, whenever I try to enter the isolated template part mode, it empties out the template part and doesn't show me the proper framing of the mode (a back button, resize handles, etc).

Step-by-step reproduction instructions

  1. Use the nightly version of 6.2 beta 2.
  2. Open Appearance > Editor.
  3. Select a template part and select "edit" in the block toolbar to enter the isolated template part mode.
  4. Notice it's broken :)

Screenshots, screen recording, code snippet

Here's a recording in replay where you can get a sense of the dev environment to replicate. If you need access, just let me know either in this issue by sharing your slack username for WordPress slack or by pinging me (@annezazu) on Make Slack.

template.part.isolated.mov

Environment info

  • WordPress 6.2-beta2-55349
  • No GB
  • TT3

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes

@annezazu annezazu added [Type] Bug An existing feature does not function as intended [Block] Template Part Affects the Template Parts Block [Feature] Focus Mode Zoomed in focus mode for editing things like template parts labels Feb 16, 2023
@annezazu annezazu moved this to 📥 Todo in WordPress 6.2 Editor Tasks Feb 16, 2023
@t-hamano
Copy link
Contributor

As far as I can tell, this problem does not seem to occur with the latest trunk. Perhaps #8063 is related. I was able to reproduce this issue by checking out the commit immediately preceding this PR (6ab9704). I believe this issue will be resolved in WordPRess 6.2 Beta3 as this PR has been given a backport label.

cc @youknowriad

@youknowriad
Copy link
Contributor

Weird that this commit impacts template parts edit mode. Kind of seems unrelated. cc @ellatrix

@ndiego
Copy link
Member

ndiego commented Feb 20, 2023

I am able to replicate it as well, which might also be related to #48216

@Mamaduka
Copy link
Member

I re-tested with WP 6.2 beta3 and could no longer reproduce the issue. The same goes for #48216.

@ndiego
Copy link
Member

ndiego commented Feb 22, 2023

I have also tested in 6.2 Beta 3 and can no longer replicate the issue. I'm going to close this out, but if anyone else continues to experience issues, please feel free to reopen. Thanks!

@ndiego ndiego closed this as completed Feb 22, 2023
@github-project-automation github-project-automation bot moved this from 📥 Todo to ✅ Done in WordPress 6.2 Editor Tasks Feb 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Template Part Affects the Template Parts Block [Feature] Focus Mode Zoomed in focus mode for editing things like template parts [Type] Bug An existing feature does not function as intended
Projects
No open projects
Development

No branches or pull requests

5 participants